[browser][CoreCLR] enable all library tests #123860

pavelsavara · 2026-02-01T21:14:26Z

testing ...

https://helix.dot.net/api/jobs/05679ccb-bca6-4ea4-9fd0-cf1b1b4d33d3/workitems?api-version=2019-06-17
https://helix.dot.net/api/jobs/dbd674cf-18dd-44a5-9323-b6c00fc9ba29/workitems?api-version=2019-06-17
https://helix.dot.net/api/jobs/075bc37c-0f7b-4cc5-b7d5-25b2ab4bcb91/workitems?api-version=2019-06-17
https://helix.dot.net/api/jobs/8d446830-7740-46cc-9970-22d32a04b8c1/workitems?api-version=2019-06-17
https://helix.dot.net/api/jobs/f18869d6-1eaf-4b5d-ad74-fa3ac619ba10/workitems?api-version=2019-06-17
https://helix.dot.net/api/jobs/86b502da-1c55-444c-ac54-2d5d4932b6f2/workitems?api-version=2019-06-17

dotnet-policy-service · 2026-02-01T21:15:28Z

Tagging subscribers to this area: @agocke, @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Copilot

Pull request overview

This PR enables library tests for the Browser+CoreCLR configuration. Previously, these tests were run in smoke-only mode with shouldRunSmokeOnly: true; this PR switches to full test execution with shouldRunSmokeOnly: false and enables error continuation mode (shouldContinueOnError: true).

Changes:

Adds project-level exclusions for 6 test projects that are completely incompatible with Browser+CoreCLR (System.IO.FileSystem.Tests, System.Reflection.MetadataLoadContext.Tests, System.Reflection.Metadata.Tests, System.Runtime.Loader.Tests, System.Diagnostics.StackTrace.Tests, System.Reflection.Tests)
Adds granular test method exclusions across ~25 test projects using [ActiveIssue] attributes for tests that fail on Browser+CoreCLR due to interpreter reflection bugs and other known issues
Implements two new native function signatures (fii and iidi) to support additional delegate and runtime test scenarios on WebAssembly
Adds debugging improvements to detect when a debugger is not attached in WASM environments
Updates native interop tables with new function mappings (SystemNative_GetEUid, SystemNative_MProtect, SystemNative_FileSystemSupportsLocking reordering)

Reviewed changes

Copilot reviewed 44 out of 44 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
eng/pipelines/runtime.yml	Enables full library test execution for Browser+CoreCLR (was smoke-only), adds continue-on-error flag
src/libraries/tests.proj	Excludes 6 test projects incompatible with Browser+CoreCLR environment
src/tasks/WasmAppBuilder/coreclr/ManagedToNativeGenerator.cs	Adds "fii" and "iidi" function signatures to support additional delegate scenarios
src/coreclr/vm/wasm/callhelpers-interp-to-managed.cpp	Implements CallFunc_I32_I32_RetF32 and CallFunc_I32_F64_I32_RetI32 for new signatures
src/coreclr/vm/wasm/callhelpers-pinvoke.cpp	Adds native function declarations (GetEUid, MProtect, FileSystemSupportsLocking), updates entry count to 100
src/coreclr/vm/wasm/callhelpers-reverse.cpp	Updates hash keys for reverse thunks (numeric key changes for consistency)
src/coreclr/pal/src/arch/wasm/stubs.cpp	Adds debugger attachment detection using time-based heuristic
src/libraries/System..Tests/.cs (25+ files)	Adds `[ActiveIssue]` attributes to disable failing tests pending issue #123011 resolution

src/coreclr/pal/src/arch/wasm/stubs.cpp

Copilot · 2026-02-01T21:24:31Z

src/libraries/System.Formats.Nrbf/tests/EdgeCaseTests.cs

    [Theory]
    [InlineData(FormatterTypeStyle.TypesAlways)]
    [InlineData(FormatterTypeStyle.TypesAlways | FormatterTypeStyle.XsdString)]
+    [SkipOnPlatform(TestPlatforms.Browser, "BinaryFormatter is not supported on Browser")]


Inconsistent attribute usage for Browser platform exclusion. In this file, lines 36 and 95 use [SkipOnPlatform(TestPlatforms.Browser, ...)], while the rest of the PR consistently uses [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))] for Browser+CoreCLR combinations.

This inconsistency suggests these tests have a different reason for being disabled (BinaryFormatter not being supported) rather than the same issue (#123011) affecting other tests. However, this should be clarified - if these are related to issue #123011, they should use the same ActiveIssue attribute pattern for consistency.

Copilot

Pull request overview

Copilot reviewed 73 out of 73 changed files in this pull request and generated 3 comments.

Copilot · 2026-02-02T18:07:01Z

src/libraries/System.Formats.Nrbf/tests/EdgeCaseTests.cs

    [Theory]
    [InlineData(FormatterTypeStyle.TypesWhenNeeded)]
    [InlineData(FormatterTypeStyle.XsdString)]
+    [SkipOnPlatform(TestPlatforms.Browser, "BinaryFormatter is not supported on Browser")]


The SkipOnPlatform attribute is inconsistent with the rest of the PR which uses ActiveIssue for the same Browser+CoreCLR combination. For consistency with other test changes in this PR, this should use ActiveIssue with the same parameters as the rest of the changes: [ActiveIssue("https://github.com/dotnet/runtime/issues/123011", typeof(PlatformDetection), nameof(PlatformDetection.IsBrowser), nameof(PlatformDetection.IsCoreCLR))]

Copilot · 2026-02-02T18:07:02Z

src/coreclr/pal/src/arch/wasm/stubs.cpp

    emscripten_debugger();
+    double end = emscripten_get_now();
+    // trying to guess if the debugger was attached
+    if (end - start < 100)


The 100ms threshold is a magic number used to determine if a debugger is attached. This value should be extracted to a named constant with a comment explaining why 100ms was chosen as the threshold. Additionally, this heuristic-based approach to detecting debugger attachment is fragile and may produce false positives/negatives depending on system load or debugger behavior.

Copilot · 2026-02-02T18:07:02Z

eng/pipelines/runtime.yml

          alwaysRun: ${{ variables.isRollingBuild }}
-          shouldRunSmokeOnly: true
-          # TODO consider shouldContinueOnError: true
+          shouldRunSmokeOnly: false


This change enables all library tests for Browser CoreCLR (not just smoke tests) but also sets shouldContinueOnError: true. This means test failures won't block the build. While this is reasonable for an experimental feature being tested, it should be clearly documented whether this is intentional behavior for the current state of Browser+CoreCLR support or if this is temporary until the linked issue is resolved.

Suggested change

shouldRunSmokeOnly: false

shouldRunSmokeOnly: false

# Browser+CoreCLR library tests are experimental; keep this leg non-blocking

# so test failures do not fail the build until Browser+CoreCLR support is stabilized.

Copilot

Pull request overview

Copilot reviewed 100 out of 100 changed files in this pull request and generated 3 comments.

Copilot · 2026-02-06T19:09:15Z

src/libraries/System.Linq/tests/OrderByDescendingTests.cs

+            if (PlatformDetection.IsBrowser && PlatformDetection.IsCoreClr && items > 1024)
+            {
+                // TODO-WASM too slow https://github.com/dotnet/runtime/issues/123011
+                return;
+            }


PlatformDetection doesn't define IsCoreClr (only IsCoreCLR / IsCoreClrInterpreter etc). This will fail to compile; use the existing PlatformDetection.IsCoreCLR property (or the intended runtime check) in this Browser+CoreCLR perf guard.

Copilot · 2026-02-06T19:09:15Z

src/mono/mono.proj

+    <!-- this is here because of python -->
+    <PackageReference Condition="'$(HostOS)' == 'windows' and '$(ShouldProvisionEmscripten)' != 'true'"
                      Include="Microsoft.NET.Runtime.Emscripten.$(EmsdkVersion).Python.win-x64"
                      PrivateAssets="all"
                      Version="$(EmsdkPackageVersion)"
                      GeneratePathProperty="true" />


This PackageReference condition depends on $(ShouldProvisionEmscripten), but that property is only set in AcquireEmscriptenSdk.targets, which is imported later in this project. During evaluation, the property will be empty here, so the condition will behave as if provisioning is not needed and can lead to incorrect/duplicate Emscripten Python package references. Consider importing AcquireEmscriptenSdk.targets before this ItemGroup, or change the condition to key off $(EMSDK_PATH) / $(TargetsBrowser) instead.

Copilot · 2026-02-06T19:09:15Z

src/coreclr/vm/wasm/callhelpers-pinvoke.cpp

    int32_t SystemNative_FTruncate (void *, int64_t);
    int32_t SystemNative_FUTimens (void *, void *);
    int32_t SystemNative_FcntlSetFD (void *, int32_t);
+    int32_t SystemNative_FileSystemSupportsLocking (void *, int32_t, int32_t);


The return type for SystemNative_FileSystemSupportsLocking is declared here as int32_t, but the native signature is uint32_t (see src/native/libs/System.Native/pal_io.h / pal_io.c). Keeping the signature consistent avoids ABI/interop mismatches and makes it clear this is a boolean-like value.

Suggested change

int32_t SystemNative_FileSystemSupportsLocking (void *, int32_t, int32_t);

uint32_t SystemNative_FileSystemSupportsLocking (void *, int32_t, int32_t);

Copilot

Pull request overview

Copilot reviewed 89 out of 89 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (3)

src/libraries/sendtohelix-wasm.targets:1

This assignment unconditionally overrides any earlier _workItemTimeout value whenever RuntimeFlavor is CoreCLR, which can unintentionally defeat more specific timeouts set above (e.g., scenario-specific timeouts). If the intent is to provide a default only when no timeout is already specified, add a guard like and '$(_workItemTimeout)' == '', or otherwise structure the conditions so the most specific timeout wins.
src/libraries/System.Linq/tests/OrderByDescendingTests.cs:1
Using return; silently turns the test into a no-op for those inputs, which can mask regressions and makes test reporting less clear. Prefer an explicit skip mechanism (e.g., an ActiveIssue/conditional attribute tied to the specific data case, or an assertion-based skip pattern used in this repo) so it's clearly reported as skipped rather than passed without executing.
src/libraries/tests.proj:1
This new path mixes \\ and / separators, while the other ProjectExclusions entries in the same block use \\. For consistency (and to avoid any edge-case path normalization differences across tooling), consider using a consistent separator style here (matching the surrounding entries).

Copilot · 2026-02-09T11:06:57Z

eng/pipelines/runtime.yml

            - browser_wasm
          alwaysRun: ${{ variables.isRollingBuild }}
-          shouldRunSmokeOnly: true
+          # shouldRunSmokeOnly: false


Commenting out shouldRunSmokeOnly removes the setting rather than setting it to false, so the pipeline will fall back to whatever default behavior is defined elsewhere (which may still be smoke-only). If the goal is to enable all library tests, set shouldRunSmokeOnly: false as an actual YAML property (not a comment).

Suggested change

# shouldRunSmokeOnly: false

shouldRunSmokeOnly: false

Copilot

Pull request overview

Copilot reviewed 109 out of 109 changed files in this pull request and generated 1 comment.

Copilot · 2026-02-10T11:47:04Z

src/libraries/sendtohelix-wasm.targets

  <PropertyGroup>
    <_workItemTimeout Condition="'$(Scenario)' == 'BuildWasmApps' and '$(_workItemTimeout)' == ''">01:30:00</_workItemTimeout>
    <_workItemTimeout Condition="'$(NeedsToBuildWasmAppsOnHelix)' == 'true'">01:00:00</_workItemTimeout>
+    <!-- TODO-WASM CoreCLR interpreter is about 7x slower than Mono at the moment -->
+    <_workItemTimeout Condition="'$(RuntimeFlavor)' == 'CoreCLR'">02:30:00</_workItemTimeout>



The CoreCLR-specific _workItemTimeout assignment will override any previously-set timeouts (e.g., the BuildWasmApps/NeedsToBuildWasmAppsOnHelix values) because the condition doesn’t check '$(_workItemTimeout)' == ''. Consider adding the same empty-check so scenario-specific settings remain effective unless no timeout was set yet.

Copilot

Pull request overview

Copilot reviewed 126 out of 126 changed files in this pull request and generated 6 comments.

Copilot · 2026-02-11T19:19:52Z

src/libraries/System.Collections.Immutable/tests/ImmutableSortedSetTest.cs

 using System.Collections.Generic;
+using System.Collections.Tests;
 using System.Diagnostics;


using System.Collections.Tests; is not used anywhere in this file. Unused usings can fail the build (warnings-as-errors); please remove it.

Copilot · 2026-02-11T19:19:53Z

src/libraries/System.Collections.Immutable/tests/ImmutableSetTest.cs

 using System.Collections.Generic;
+using System.Collections.Tests;
 using System.Linq;


using System.Collections.Tests; is not used anywhere in this file. Unused usings can fail the build (warnings-as-errors); please remove it.

Copilot · 2026-02-11T19:19:53Z

src/libraries/System.Collections.Immutable/tests/ImmutableHashSetTest.cs


 using System.Collections.Generic;
+using System.Collections.Tests;
 using System.Diagnostics;


using System.Collections.Tests; is not used anywhere in this file. Unused usings can fail the build (warnings-as-errors); please remove it.

Suggested change

using System.Diagnostics;

Copilot · 2026-02-11T19:19:53Z

src/libraries/System.Collections.Immutable/tests/ImmutableHashSetTest.nonnetstandard.cs

 // The .NET Foundation licenses this file to you under the MIT license.

 using System.Collections.Generic;
+using System.Collections.Tests;


using System.Collections.Tests; is not used anywhere in this file. Unused usings can fail the build (warnings-as-errors); please remove it.

Suggested change

using System.Collections.Tests;

Copilot · 2026-02-11T19:19:53Z

src/libraries/System.Collections.Immutable/tests/Frozen/FrozenFromKnownValuesTests.cs

 using System.Collections.Generic;
+using System.Collections.Tests;
 using System.Linq;
 using System.Runtime.CompilerServices;


using System.Collections.Tests; is not used anywhere in this file. Unused usings can fail the build (warnings-as-errors); please remove it.

Suggested change

using System.Runtime.CompilerServices;

Copilot · 2026-02-11T19:19:54Z

src/libraries/System.Runtime.Serialization.Xml/tests/DataContractSerializerStressTests.cs

 // Licensed to the .NET Foundation under one or more agreements.
 // The .NET Foundation licenses this file to you under the MIT license.

+using System;


using System; appears to be unused in this file (no System.* types are referenced). With warnings treated as errors, this can break the build; please remove the unused using (or add a usage if intended).

pavelsavara added this to the 11.0.0 milestone Feb 1, 2026

pavelsavara self-assigned this Feb 1, 2026

pavelsavara added arch-wasm WebAssembly architecture area-Infrastructure-coreclr os-browser Browser variant of arch-wasm labels Feb 1, 2026

Copilot AI review requested due to automatic review settings February 1, 2026 21:14

github-project-automation bot added this to Runtime Infra Feb 1, 2026

Copilot started reviewing on behalf of pavelsavara February 1, 2026 21:15 View session

Copilot AI reviewed Feb 1, 2026

View reviewed changes

Copilot AI review requested due to automatic review settings February 2, 2026 17:56

Copilot started reviewing on behalf of pavelsavara February 2, 2026 17:57 View session

Copilot AI reviewed Feb 2, 2026

View reviewed changes

pavelsavara added 6 commits February 3, 2026 14:20

initial

3c4db7c

aquire emsdk for coreCLR

864e9c3

fix mono

eae8e05

fix

1e0e1d0

fix

e80dd23

Merge branch 'main' into aquire_emsdk

3598bcf

fix

f54b25e

Copilot AI reviewed Feb 6, 2026

View reviewed changes

fix

21c989a

This was referenced Feb 7, 2026

"We stopped hearing from agent Azure Pipelines 32. Verify the agent machine is running and has a healthy network connection" dotnet/dnceng#1886

Open

Crossgen2 coreroot_determinism test failure (exit code 134) #124052

Closed

Merge branch 'main' into library_tests_ci

6843707

Copilot AI review requested due to automatic review settings February 9, 2026 10:54

Copilot started reviewing on behalf of pavelsavara February 9, 2026 10:55 View session

Merge branch 'main' into library_tests_ci

1d698b8

Copilot AI reviewed Feb 9, 2026

View reviewed changes

This was referenced Feb 9, 2026

Android System.Security.Cryptography test failure: Signing key verifies the CRL #119023

Open

CryptographicException in NonPowerOfTwoKeySizeOaepRoundtrip test #120606

Open

disable more tests + timeouts

b021385

This was referenced Feb 9, 2026

Checkout failure: "Git fetch failed with exit code 128" dotnet/arcade#9009

Open

Unable to checkout dotnet/dnceng#4115

Open

Unable to pull image from mcr.microsoft.com #117164

Open

pavelsavara added 3 commits February 10, 2026 09:25

Merge branch 'main' into library_tests_ci

fa46a6f

active issue

cb36979

more

0157f50

Copilot AI review requested due to automatic review settings February 10, 2026 11:36

Copilot started reviewing on behalf of pavelsavara February 10, 2026 11:38 View session

Copilot AI reviewed Feb 10, 2026

View reviewed changes

disable slow tests

5323b8e

build-analysis bot mentioned this pull request Feb 10, 2026

tracing/runtimeeventsource/nativeruntimeeventsource/nativeruntimeeventsource failing in CI #90605

Open

pavelsavara added 2 commits February 11, 2026 20:08

more

84bfe8a

Merge remote-tracking branch 'upstream/main' into library_tests_ci

05c6b0a

Copilot AI review requested due to automatic review settings February 11, 2026 19:09

Copilot started reviewing on behalf of pavelsavara February 11, 2026 19:10 View session

Copilot AI reviewed Feb 11, 2026

View reviewed changes

This was referenced Feb 12, 2026

[android] Android.Device_Emulator.JIT.Test failing on emulators with CoreCLR #112633

Open

System.Security.Cryptography.CryptographicException : m_safeCertContext is an invalid handle. #124279

Open

	int32_t SystemNative_FileSystemSupportsLocking (void *, int32_t, int32_t);
	uint32_t SystemNative_FileSystemSupportsLocking (void *, int32_t, int32_t);

[browser][CoreCLR] enable all library tests #123860

Are you sure you want to change the base?

[browser][CoreCLR] enable all library tests #123860

Uh oh!

Conversation

pavelsavara commented Feb 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-policy-service bot commented Feb 1, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI Feb 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 2, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 9, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

pavelsavara commented Feb 1, 2026 •

edited

Loading