Sve2: Add ShiftRightLogicalNarrowingSaturate(Even|Odd) #123888
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
community-contribution
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds ShiftRightLogicalNarrowingSaturateEven and ShiftRightLogicalNarrowingSaturateOdd intrinsics to the Arm SVE2 instruction set. These saturating shift right operations narrow the data type while preventing overflow.
Changes:
- Added six new API signatures across different unsigned integer type combinations (byte/ushort, ushort/uint, uint/ulong)
- Integrated corresponding test generation entries for both Even and Odd variants
- Registered the intrinsics in the JIT compiler's hardware intrinsic list
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs | Added test generation entries for the six new intrinsic variants |
| src/libraries/System.Runtime.Intrinsics/ref/System.Runtime.Intrinsics.cs | Added public API surface declarations for the new intrinsics |
| src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.cs | Implemented the intrinsic methods with proper documentation |
| src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.PlatformNotSupported.cs | Added PlatformNotSupportedException stubs for unsupported platforms |
| src/coreclr/jit/hwintrinsiclistarm64sve.h | Registered the new intrinsics in the JIT's hardware intrinsic mapping table |
Comments suppressed due to low confidence (2)
src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs:1
- The helper method names use "ShiftRightArithmetic" but should be "ShiftRightLogical" to match the intrinsic being tested (ShiftRightLogicalNarrowingSaturateEven).
// Licensed to the .NET Foundation under one or more agreements.
src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs:1
- The helper method names use "ShiftRightArithmetic" but should be "ShiftRightLogical" to match the intrinsic being tested (ShiftRightLogicalNarrowingSaturateOdd).
// Licensed to the .NET Foundation under one or more agreements.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Contributor
Author
|
@dotnet/arm64-contrib |
This was referenced Feb 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (6)
src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs:1
- The helper methods referenced in ValidateIterResult and GetIterResult use "ShiftRightArithmeticNarrowingSaturateEven" but should be "ShiftRightLogicalNarrowingSaturateEven" to match the method being tested (ShiftRightLogicalNarrowingSaturateEven).
// Licensed to the .NET Foundation under one or more agreements.
src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs:1
- The helper methods referenced in ValidateIterResult and GetIterResult use "ShiftRightArithmeticNarrowingSaturateEven" but should be "ShiftRightLogicalNarrowingSaturateEven" to match the method being tested (ShiftRightLogicalNarrowingSaturateEven).
// Licensed to the .NET Foundation under one or more agreements.
src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs:1
- The helper methods referenced in ValidateIterResult and GetIterResult use "ShiftRightArithmeticNarrowingSaturateEven" but should be "ShiftRightLogicalNarrowingSaturateEven" to match the method being tested (ShiftRightLogicalNarrowingSaturateEven).
// Licensed to the .NET Foundation under one or more agreements.
src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs:1
- The helper methods referenced in ValidateIterResult and GetIterResult use "ShiftRightArithmeticNarrowingSaturateOdd" but should be "ShiftRightLogicalNarrowingSaturateOdd" to match the method being tested (ShiftRightLogicalNarrowingSaturateOdd).
// Licensed to the .NET Foundation under one or more agreements.
src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs:1
- The helper methods referenced in ValidateIterResult and GetIterResult use "ShiftRightArithmeticNarrowingSaturateOdd" but should be "ShiftRightLogicalNarrowingSaturateOdd" to match the method being tested (ShiftRightLogicalNarrowingSaturateOdd).
// Licensed to the .NET Foundation under one or more agreements.
src/tests/Common/GenerateHWIntrinsicTests/Arm/Sve2Tests.cs:1
- The helper methods referenced in ValidateIterResult and GetIterResult use "ShiftRightArithmeticNarrowingSaturateOdd" but should be "ShiftRightLogicalNarrowingSaturateOdd" to match the method being tested (ShiftRightLogicalNarrowingSaturateOdd).
// Licensed to the .NET Foundation under one or more agreements.
This was referenced Feb 4, 2026
Open
tannergooding
approved these changes
Feb 5, 2026
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122022