Remove unused method signatures from corelib and metasig headers #124011
+0
−142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @agocke |
Contributor
There was a problem hiding this comment.
Pull request overview
Removes CoreLibBinder entries and metasig declarations that are no longer referenced by CoreCLR, reducing maintenance surface in the VM’s corelib and metasig header tables.
Changes:
- Pruned a large set of unused
DEFINE_METASIG*signature entries frommetasig.h. - Removed unused CoreLibBinder bindings for
Task.FromException*,ValueTask.FromException*,DBNull.Value,Type.IsImport, and a redundant custom marshaler binding fromcorelib.h.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/coreclr/vm/metasig.h | Removes unused metasig signature definitions to shrink the signature table. |
| src/coreclr/vm/corelib.h | Drops unused CoreLibBinder member bindings that are no longer referenced by the runtime. |
jkotas
approved these changes
Feb 4, 2026
Removed commented-out section for FailFast in metasig.h
jkoritzinsky
approved these changes
Feb 4, 2026
elinor-fung
approved these changes
Feb 4, 2026
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.