Disable failing ToString_Async test on Apple mobile with CoreCLR R2R and interpreter #124037
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
needs-area-label
kotlarmilos
added
os-ios
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes a garbage collection protection bug in the AsyncHelpers_AddContinuationToExInternal function by adding GCPROTECT_BEGIN and GCPROTECT_END around the call to StackTraceInfo::AppendElement. This function was introduced in PR #122722 which implemented runtime-async exception stack trace collection.
Changes:
- Added GCPROTECT for the exception object reference in
AsyncHelpers_AddContinuationToExInternalto prevent crashes from GC moving the object during stack trace appending - Removed trailing whitespace from multiple lines throughout the file for code formatting consistency
jkotas
reviewed
Feb 5, 2026
kotlarmilos
changed the title
jkotas
reviewed
Feb 5, 2026
src/libraries/System.Diagnostics.StackTrace/tests/StackTraceTests.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
Feb 5, 2026
jkotas
reviewed
Feb 5, 2026
Member
|
/ba-g Unrelated tvos crash with no actionable details "App terminated due to signal 11" |
lewing
pushed a commit
to lewing/runtime
that referenced
this pull request
Feb 9, 2026
…and interpreter (dotnet#124037) ## Description This PR disables failing test ToString_Async on Apple mobile. Tracking issue dotnet#124044 --------- Co-authored-by: Jan Kotas <jkotas@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR disables failing test ToString_Async on Apple mobile.
Tracking issue #124044