Remove redundant checked contexts around casts + more bounds checks#124184
Merged
EgorBo merged 5 commits intodotnet:mainfrom Feb 11, 2026
Merged
Remove redundant checked contexts around casts + more bounds checks#124184EgorBo merged 5 commits intodotnet:mainfrom
EgorBo merged 5 commits intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends JIT assertion-based reasoning to (1) remove redundant overflow checks/casts when proven safe by range info and (2) enable additional bounds-check eliminations from inferred constant ranges.
Changes:
- Promote
RangeCheck::GetRangeFromTypeto be callable from assertion propagation, enabling range comparisons for cast redundancy decisions. - Enhance
MergeEdgeAssertionsto inferarr.Length > 0from certain non-constant index assertions. - Add range-based bounds check elimination and adjust assertion-based non-negative/non-zero inference.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/coreclr/jit/rangecheck.h | Exposes GetRangeFromType for external (assertionprop) range reasoning. |
| src/coreclr/jit/rangecheck.cpp | Improves edge-assertion merge logic, including deducing Length > 0 in more cases. |
| src/coreclr/jit/assertionprop.cpp | Uses range reasoning to remove redundant casts/overflow checks and drop more bounds checks. |
This was referenced Feb 9, 2026
Member
Author
|
/azp run Fuzzlyn |
|
Azure Pipelines successfully started running 1 pipeline(s). |
EgorBo
commented
Feb 11, 2026
EgorBo
commented
Feb 11, 2026
Member
Author
|
PTAL @jakobbotsch @dotnet/jit-contrib |
jakobbotsch
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example of a removed checked context:
Diffs