-
Notifications
You must be signed in to change notification settings - Fork 5.3k
[RuntimeAsync] Enable runtime async in Libraries partition #124527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -99,4 +99,8 @@ | |||||
| <CoverageIncludeDirectory Include="shared\Microsoft.NETCore.App\$(ProductVersion)" /> | ||||||
| </ItemGroup> | ||||||
|
|
||||||
| <PropertyGroup> | ||||||
| <Features Condition="'$(RuntimeFlavor)' != 'mono' and '$(TestBuildMode)' != 'nativeaot' and '$(TargetArchitecture)' != 'wasm'">$(Features);runtime-async=on</Features> | ||||||
| <NoWarn>$(NoWarn);SYSLIB5007</NoWarn> | ||||||
|
||||||
| <NoWarn>$(NoWarn);SYSLIB5007</NoWarn> |
Copilot
AI
Feb 17, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing whitespace detected after the closing tag. According to .editorconfig, all files should have trim_trailing_whitespace = true. Please remove the trailing spaces at the end of this line.
| </PropertyGroup> | |
| </PropertyGroup> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition for enabling runtime-async differs from the one in eng/testing/tests.targets in several ways:
This uses
TargetArchitecture != 'wasm'while tests.targets usesTargetOS != 'browser' and TargetOS != 'wasi'. Note that WASM projects set TargetArchitecture='wasm' but have TargetOS='browser' or 'wasi', so these conditions are not equivalent.This doesn't check for TestReadyToRun, while tests.targets excludes it explicitly.
This doesn't check for TargetsAppleMobile, while tests.targets excludes it.
This doesn't allow opting out via UseRuntimeAsync='false', while tests.targets does.
This uses TestBuildMode != 'nativeaot' while tests.targets uses multiple NativeAOT-related properties (TestNativeAot, UseNativeAOTRuntime).
Consider aligning these conditions for consistency, or document why the libraries partition needs different criteria. The TargetArchitecture != 'wasm' check in particular may not correctly handle browser/wasi scenarios since those have TargetOS='browser'/'wasi' but TargetArchitecture='wasm'.