Fix CompareInfo and SQL tests #1254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@krwq could you please have a look? Thanks! |
krwq
reviewed
Jan 2, 2020
src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlStringSortingTest.cs
Show resolved
Hide resolved
krwq
reviewed
Jan 2, 2020
src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlStringSortingTest.cs
Show resolved
Hide resolved
krwq
reviewed
Jan 2, 2020
src/libraries/System.Data.Common/tests/System/Data/SqlTypes/SqlStringSortingTest.cs
Show resolved
Hide resolved
krwq
approved these changes
Jan 2, 2020
krwq
reviewed
Jan 2, 2020
src/libraries/System.Globalization/tests/CompareInfo/CompareInfoTests.Compare.cs
Outdated
Show resolved
Hide resolved
krwq
approved these changes
Jan 2, 2020
|
The arm CI has been broken for some time now. #1097 is tracking this. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1164
Windows has some regression for handling strings containing Kana characters. The issue is reported to the Windows team and expected to get the fix soon. The changes here are fixing the tests to avoid the failures on the regressed version of Windows.