Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get culture info with supported predefined flag #1259

Closed

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jan 2, 2020

This PR implements the approved feature dotnet/corefx#32201

@tarekgh
Copy link
Member Author

tarekgh commented Jan 2, 2020

This PR is revert to the revert of the #654 which originally reviewed by @danmosemsft and @stephentoub. I reverted the original PR because only doubted some missing part but after reverting I found everything is there so I am resubmitting it back.

@tarekgh
Copy link
Member Author

tarekgh commented Jan 2, 2020

@krwq sorry for the inconvenience. could you please approve this one? as I mentioned this is already reviewed before in #654.

@danmosemsft please have a quick look if you have a minute.

@tarekgh
Copy link
Member Author

tarekgh commented Jan 3, 2020

I decided to revert the other revert #1257 instead of submitting this one.

@tarekgh tarekgh closed this Jan 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
@tarekgh tarekgh deleted the GetCultureInfoWithSupportedPredefinedFlag branch March 15, 2021 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants