improve cert validation diagnostic on OSX #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bartonjs
reviewed
Jan 9, 2020
src/libraries/Native/Unix/System.Security.Cryptography.Native.Apple/pal_ssl.c
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 9, 2020
src/libraries/Native/Unix/System.Security.Cryptography.Native.Apple/pal_ssl.c
Outdated
Show resolved
Hide resolved
bartonjs
reviewed
Jan 9, 2020
src/libraries/Native/Unix/System.Security.Cryptography.Native.Apple/pal_ssl.c
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 9, 2020
src/libraries/Native/Unix/System.Security.Cryptography.Native.Apple/pal_ssl.c
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 9, 2020
src/libraries/Native/Unix/System.Security.Cryptography.Native.Apple/pal_ssl.c
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 9, 2020
src/libraries/System.Net.Security/src/System/Net/CertificateValidationPal.OSX.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 9, 2020
bartonjs
reviewed
Jan 9, 2020
src/libraries/Native/Unix/System.Security.Cryptography.Native.Apple/pal_ssl.c
Outdated
Show resolved
Hide resolved
bartonjs
approved these changes
Jan 9, 2020
stephentoub
reviewed
Jan 10, 2020
src/libraries/Common/src/Interop/OSX/System.Security.Cryptography.Native.Apple/Interop.Ssl.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when OS does not like remote certificate it is quite difficult to figure out why. (like #666)
This change will try to extract reason code from OS and it will emit tracing entry so it is possible to get to it easily.
will produce something like
In this case that can be mapped to
CSSMERR_APPLETP_INVALID_EXTENDED_KEY_USAGEfor case described in #666 or toCSSMERR_APPLETP_CA_PIN_MISMATCHin #805related to #666
related to #805
contributes to https://github.com/dotnet/corefx/issues/34905