-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation refinements #1738
Conversation
|
||
## Building Individual Tests | ||
|
||
During development there are many instances where building an individual test is fast and necessary. All of the necessary tools to build are under `coreclr`. It is possible to use `runtime/.dotnet/dotnet msbuild` as you would normally use MSBuild with a few caveats. | ||
During development there are many instances where building an individual test is fast and necessary. All of the necessary tools to build are under `coreclr`. It is possible to use `~/runtime/dotnet msbuild` as you would normally use MSBuild with a few caveats. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
~/runtime/dotnet
is a script right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I'll make it more clear.
|
||
**!! Note !! -- Passing /p:__BuildOs=[OSX|Linux] is required.** | ||
|
||
## Building an Individual Test | ||
|
||
>`/path/to/runtime/.dotnet/dotnet msbuild src/coreclr/tests/src/path-to-proj-file /p:__BuildOS=<BuildOS> /p:__BuildType=<BuildType>` | ||
``` | ||
/path/to/runtime/dotnet msbuild src/coreclr/tests/src/path-to-proj-file /p:__BuildOS=<BuildOS> /p:__BuildType=<BuildType> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI @ViktorHofer who is updating these properties to be consistent across partitions... this will need to be updated as part of your change.
a94a715
to
213a501
Compare
Thanks for doing this @BruceForstall . I hope we continue to tune and improve these docs - they're important ... |
@danmosemsft I think they still need more work. Mac builds still don't work (#1461). And we need some of the suggestions in #839 implemented to simplify dev workflow. The docs don't describe the suggestion in #839 that, for coreclr anyway, you build everything Release before iterating on coreclr in debug/checked. So either that's no longer necessary, or not adequately described. |
@BruceForstall it looks like @jkoritzinsky will make a relevant update in #1826 Aside from that, whenever I'm aware they're incorrect and I feel qualified to improve them, I hope to do so 😃 |
No description provided.