Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Apline.38 ARM64 runs #1873

Merged
merged 1 commit into from
Jan 18, 2020
Merged

Disable Apline.38 ARM64 runs #1873

merged 1 commit into from
Jan 18, 2020

Conversation

jaredpar
Copy link
Member

These are consistently failing on all runs. Disabling to get the build
green again while we dig into this

#1871

These are consistently failing on all runs. Disabling to get the build
green again while we dig into this

dotnet#1871
Copy link
Contributor

@sdmaclea sdmaclea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sdmaclea sdmaclea changed the title Disable Apline.38 ARM runs Disable Apline.38 ARM64 runs Jan 17, 2020
@jaredpar jaredpar merged commit f630c07 into dotnet:master Jan 18, 2020
@jaredpar jaredpar deleted the standard branch January 18, 2020 01:12
@safern
Copy link
Member

safern commented Jan 27, 2020

As a note this is not the best way to disable test runs because the test runs still try to send to helix but with an empty set of queues, causing the build to fail with error:

You must specify at least one target queue to send a job to helix. Use the HelixTargetQueues property or HelixTargetQueue items.

https://dev.azure.com/dnceng/public/_build/results?buildId=497977

Libraries run-test-job.yml is not resilient to empty helix queues as coreclr's ones. I don't like skipping the send to helix step when there are no queues because that's prone to errors if by mistake we aren't passing the right queues to a job we want to run and it would take a while to notice.

The way I would recommend to disable test runs in the future if by commenting directly in runtime.yml the platform entry, in this case I would've commented this:
https://github.com/dotnet/runtime/blob/master/eng/pipelines/runtime.yml#L563

The issue referenced on this PR, will soon be fixed, so there is no point on sending a PR to fix this new error and instead wait for the fix which will be sent soon and re-enable the queues setup.

@jaredpar
Copy link
Member Author

The way I would recommend to disable test runs in the future if by commenting directly in runtime.yml the platform entry, in this case I would've commented this

That line you linked is the following:

 helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml

Did you mean to comment out that line?

@safern
Copy link
Member

safern commented Jan 28, 2020

No sorry about that, I meant this line:

- Linux_musl_arm64

@jaredpar
Copy link
Member Author

Gotcha. That makes sense. Essentially kill teh platform at the higher level.

@safern
Copy link
Member

safern commented Jan 28, 2020

Essentially kill teh platform at the higher level.

Exactly.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants