-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable Apline.38 ARM64 runs #1873
Conversation
These are consistently failing on all runs. Disabling to get the build green again while we dig into this dotnet#1871
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As a note this is not the best way to disable test runs because the test runs still try to send to helix but with an empty set of queues, causing the build to fail with error:
https://dev.azure.com/dnceng/public/_build/results?buildId=497977 Libraries run-test-job.yml is not resilient to empty helix queues as coreclr's ones. I don't like skipping the send to helix step when there are no queues because that's prone to errors if by mistake we aren't passing the right queues to a job we want to run and it would take a while to notice. The way I would recommend to disable test runs in the future if by commenting directly in runtime.yml the platform entry, in this case I would've commented this: The issue referenced on this PR, will soon be fixed, so there is no point on sending a PR to fix this new error and instead wait for the fix which will be sent soon and re-enable the queues setup. |
That line you linked is the following: helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml Did you mean to comment out that line? |
No sorry about that, I meant this line: runtime/eng/pipelines/runtime.yml Line 560 in 6a8603b
|
Gotcha. That makes sense. Essentially kill teh platform at the higher level. |
Exactly. |
These are consistently failing on all runs. Disabling to get the build
green again while we dig into this
#1871