Fix AV in System.StubHelpers.CSTRMarshaler.ConvertFixedToNative #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like a regression introduced by dotnet/coreclr#26340. @jkoritzinsky Could you please take a look? Do we need a test for this? |
jkotas
reviewed
Nov 22, 2019
src/coreclr/src/System.Private.CoreLib/src/System/StubHelpers.cs
Outdated
Show resolved
Hide resolved
src/coreclr/src/System.Private.CoreLib/src/System/StubHelpers.cs
Outdated
Show resolved
Hide resolved
|
I will add the minimal repro as a regression test |
jkoritzinsky
approved these changes
Nov 22, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found using the latest runtime on a WPF app (https://github.com/ridomin/msix-catalog)