[mono][xunit tests] Move skipped tests out of rsp file

eng/testing/tests.targets

@@ -80,7 +80,6 @@
  <!-- TODO: remove when rsp files are removed: https://github.com/dotnet/runtime/issues/1980. -->
  <ItemGroup>
  <_rspFile Include="$(TestRspFile)" Condition="'$(TestRspFile)' != ''" />
- <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues.rsp" />
  <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_mac.rsp" Condition="'$(TargetOS)' == 'OSX'" />
  <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_linux.rsp" Condition="'$(TargetOS)' == 'Linux'" />
  <_rspFile Include="$(MonoProjectRoot)netcore\CoreFX.issues_windows.rsp" Condition="'$(TargetOS)' == 'Windows_NT'" />

src/libraries/Common/tests/CoreFx.Private.TestUtilities/System/PlatformDetection.cs

@@ -33,6 +33,8 @@ public static partial class PlatformDetection
  public static bool IsArgIteratorNotSupported => !IsArgIteratorSupported;
  public static bool Is32BitProcess => IntPtr.Size == 4;
 
+ // Please make sure that you have the libgdiplus dependency installed.
+ // For details, see https://docs.microsoft.com/dotnet/core/install/dependencies?pivots=os-macos&tabs=netcore31#libgdiplus
  public static bool IsDrawingSupported
  {
  get

src/libraries/Microsoft.VisualBasic.Core/tests/ErrObjectTests.cs

@@ -11,6 +11,7 @@ namespace Microsoft.VisualBasic.Tests
  public class ErrObjectTests
  {
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/14854", TestRuntimes.Mono)]
  public void Clear()
  {
  ProjectData.ClearProjectError();

src/libraries/Microsoft.VisualBasic.Core/tests/InteractionTests.cs

@@ -138,6 +138,7 @@ public static IEnumerable<object[]> IIf_TestData()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
  public void DeleteSetting()
  {
  if (!PlatformDetection.IsInAppContainer)
@@ -207,6 +208,7 @@ private static (string, string)[] GetEnvironmentVariables()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
  public void GetAllSettings()
  {
  if (!PlatformDetection.IsInAppContainer)
@@ -221,6 +223,7 @@ public void GetAllSettings()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
  public void GetSetting()
  {
  if (!PlatformDetection.IsInAppContainer)
@@ -301,14 +304,14 @@ public void Partition_Overflow(long Number, long Start, long Stop, long Interval
  {
  Assert.Throws<OverflowException>(() => Interaction.Partition(Number, Start, Stop, Interval));
  }
- 
+
  [Fact]
+ [ActiveIssue("https://github.com/dotnet/runtime/issues/2139", TestRuntimes.Mono)]
  public void SaveSetting()
  {
  if (!PlatformDetection.IsInAppContainer)
  {
  Assert.Throws<ArgumentException>(() => Interaction.SaveSetting(AppName: "", Section: "", Key: "", Setting: ""));
-
  }
  else
  {

src/libraries/System.Collections.Concurrent/tests/ConcurrentQueueTests.cs

@@ -212,6 +212,7 @@ public void IEnumerable_GetAllExpectedItems()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16413", TestRuntimes.Mono)]
  public void ReferenceTypes_NulledAfterDequeue()
  {
  int iterations = 10; // any number <32 will do

src/libraries/System.Collections.Specialized/tests/NameValueCollection/NameValueCollection.CtorTests.cs

@@ -68,6 +68,7 @@ public void Ctor_Int(int capacity)
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/14858", TestRuntimes.Mono)]
  public void Ctor_NegativeCapacity_ThrowsArgumentOutOfRangeException()
  {
  AssertExtensions.Throws<ArgumentOutOfRangeException>("capacity", () => new NameValueCollection(-1));

src/libraries/System.ComponentModel.Composition.Registration/tests/AssemblyInfo.cs

@@ -0,0 +1,7 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using Xunit;
+
+[assembly: SkipOnMono("System.ComponentModel.Composition.Registration APIs are not supported on this platform")]

src/libraries/System.ComponentModel.Composition.Registration/tests/System.ComponentModel.Composition.Registration.Tests.csproj

@@ -3,6 +3,7 @@
  <TargetFrameworks>$(NetCoreAppCurrent)</TargetFrameworks>
  </PropertyGroup>
  <ItemGroup>
+ <Compile Include="AssemblyInfo.cs" />
  <Compile Include="InternalCalls.cs" />
  <Compile Include="System\ComponentModel\Composition\Registration\ExportBuilderTests.cs" />
  <Compile Include="System\ComponentModel\Composition\Registration\ExportBuilderUnitTests.cs" />

src/libraries/System.ComponentModel.Composition/tests/AssemblyInfo.cs

@@ -0,0 +1,7 @@
+// Licensed to the .NET Foundation under one or more agreements.
+// The .NET Foundation licenses this file to you under the MIT license.
+// See the LICENSE file in the project root for more information.
+
+using Xunit;
+
+[assembly: SkipOnMono("Flaky tests: https://github.com/mono/mono/issues/16417")]

src/libraries/System.ComponentModel.Composition/tests/System.ComponentModel.Composition.Tests.csproj

@@ -16,6 +16,7 @@
  <Compile Include="$(CommonTestPath)System\IO\TempFile.cs">
  <Link>Common\System\IO\TempFile.cs</Link>
  </Compile>
+ <Compile Include="AssemblyInfo.cs" />
  <Compile Include="IMetadataView.cs" />
  <Compile Include="MetadataTests_IMetadataView.cs" />
  <Compile Include="System\LazyHelper.cs" />

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AdvancedValueComposition.cs

@@ -24,6 +24,7 @@ public interface ITrans_CollectionOfStrings
  public class AdvancedValueComposition
  {
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void RepeatedContainerUse()
  {
  var container = ContainerFactory.Create();
@@ -41,6 +42,7 @@ public void RepeatedContainerUse()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void FunctionsFieldsAndProperties()
  {
  Consumer c;
@@ -55,6 +57,7 @@ public void FunctionsFieldsAndProperties()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void FunctionsFieldsAndProperties2()
  {
  Consumer c;
@@ -252,6 +255,7 @@ public void ImportIntoUntypedExportTest()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportIntoDerivationOfExportException()
  {
  var container = ContainerFactory.Create();
@@ -269,6 +273,7 @@ public void ImportIntoDerivationOfExportException()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportIntoDerivationOfExportsException()
  {
  var container = ContainerFactory.Create();

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AllowNonPublicCompositionTests.cs

@@ -8,9 +8,11 @@
 
 namespace System.ComponentModel.Composition
 {
+ // [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public class AllowNonPublicCompositionTests
  {
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void PublicFromPublic()
  {
  var container = ContainerFactory.Create();
@@ -25,6 +27,7 @@ public void PublicFromPublic()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void PublicToSelf()
  {
  var container = ContainerFactory.Create();
@@ -38,6 +41,7 @@ public void PublicToSelf()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void PublicFromPrivate()
  {
  var container = ContainerFactory.Create();
@@ -52,6 +56,7 @@ public void PublicFromPrivate()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void PrivateFromPublic()
  {
  var container = ContainerFactory.Create();
@@ -66,6 +71,7 @@ public void PrivateFromPublic()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void PrivateToSelf()
  {
  var container = ContainerFactory.Create();
@@ -79,6 +85,7 @@ public void PrivateToSelf()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void PrivateData()
  {
  var container = ContainerFactory.Create();

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelCompositionTests.cs

@@ -10,6 +10,7 @@
 
 namespace System.ComponentModel.Composition.AttributedModel
 {
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public class AttributedModelCompositionTests
  {
  [Fact]

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/AttributedModelDiscoveryTests.cs

@@ -16,6 +16,7 @@ namespace System.ComponentModel.Composition.AttributedModel
  public class AttributedModelDiscoveryTests
  {
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void CreatePartDefinition_TypeWithExports_ShouldHaveMultipleExports()
  {
  var definition = CreateDefinition(typeof(PublicComponentWithPublicExports));
@@ -34,6 +35,7 @@ public class DerivedClassWithInheritedPropertyExports : BaseClassWithPropertyExp
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void CreatePartDefinition_TypeWithImports_ShouldHaveMultipleImports()
  {
  var definition = CreateDefinition(typeof(PublicImportsExpectingPublicExports));
@@ -156,6 +158,7 @@ public void CreatePartDefinition_MultipleMarkedConstructorsAsPartTypeArgument_Sh
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked()
  {
  var definition = CreateDefinition(typeof(SimpleConstructorInjectedObject));
@@ -167,6 +170,7 @@ public void CreatePartDefinition_OneMarkedConstructorsAsPartTypeArgument_ShouldS
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldSetConstructorToDefault()
  {
  var definition = CreateDefinition(typeof(PublicComponentWithPublicExports));
@@ -179,6 +183,7 @@ public void CreatePartDefinition_OneDefaultConstructorAsPartTypeArgument_ShouldS
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void CreatePartDefinition_OneMarkedAndOneDefaultConstructorsAsPartTypeArgument_ShouldSetConstructorToMarked()
  {
  var definition = CreateDefinition(typeof(ClassWithOneMarkedAndOneDefaultConstructor));

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModel/INotifyImportTests.cs

@@ -23,6 +23,7 @@ public void OnImportsSatisfied()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportsSatisfiedOnComponentWithoutImports()
  {
  CompositionContainer container = ContainerFactory.CreateWithAttributedCatalog(typeof(PartWithoutImports));
@@ -35,6 +36,7 @@ public void ImportsSatisfiedOnComponentWithoutImports()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportCompletedTest()
  {
  var container = ContainerFactory.Create();
@@ -56,6 +58,7 @@ public void ImportCompletedTest()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportCompletedWithRecomposing()
  {
  var container = ContainerFactory.Create();
@@ -94,6 +97,7 @@ public void ImportCompletedWithRecomposing()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportCompletedAddPartAndBindComponent()
  {
  var container = ContainerFactory.Create();

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/AttributedModelServicesTests.cs

@@ -145,6 +145,7 @@ public void Imports_Throws_OnNullContractName()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void Imports()
  {
  ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
@@ -158,6 +159,7 @@ public void Imports()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void Imports_CardinalityIgnored_WhenNotSpecified()
  {
  ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
@@ -170,6 +172,7 @@ public void Imports_CardinalityIgnored_WhenNotSpecified()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void Imports_CardinalityNotIgnored_WhenSpecified()
  {
  ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
@@ -200,6 +203,7 @@ public void ImportsGeneric_Throws_OnNullPart()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportsGeneric()
  {
  ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
@@ -213,6 +217,7 @@ public void ImportsGeneric()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified()
  {
  ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();
@@ -225,6 +230,7 @@ public void ImportsGeneric_CardinalityIgnored_WhenNotSpecified()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void ImportsGeneric_CardinalityNotIgnored_WhenSpecified()
  {
  ComposablePartDefinition part1 = typeof(PartImportingContract1).AsPart();

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/ComponentServicesTests.cs

@@ -74,6 +74,7 @@ public void GetValuesTest()
  }
 
  [Fact]
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public void NoResolverExceptionTest()
  {
  var container = ContainerFactory.Create();

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerCollectionTests.cs

@@ -13,6 +13,7 @@
 
 namespace System.ComponentModel.Composition
 {
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public class CompositionContainerCollectionTests
  {
  public class SupportedImportCollectionAssignments<T>

src/libraries/System.ComponentModel.Composition/tests/System/ComponentModel/Composition/CompositionContainerImportTests.cs

@@ -13,6 +13,7 @@
 
 namespace System.ComponentModel.Composition
 {
+ [ActiveIssue("https://github.com/mono/mono/issues/16417", TestRuntimes.Mono)]
  public class CompositionContainerImportTests
  {
  // Exporting collectin values is not supported