Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reenable Http2_ServerSendsInvalidSettingsValue_Error test #2134

Merged
merged 1 commit into from
Jan 24, 2020
Merged

Reenable Http2_ServerSendsInvalidSettingsValue_Error test #2134

merged 1 commit into from
Jan 24, 2020

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Jan 24, 2020

It seems like we did not pass properly SettingsEntry in H2LoopbackServer.
Tests are passing now.

    Discovering: System.Net.Http.Functional.Tests (method display = ClassAndMethod, method display options = None)
    Discovered:  System.Net.Http.Functional.Tests (found 1 of 1148 test case)
    Starting:    System.Net.Http.Functional.Tests (parallel test collections = on, max threads = 4)
      System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_ServerSendsInvalidSettingsValue_Error(settingId: MaxFrameSize, value: 16383, expectedError: PROTOCOL_ERROR) [STARTING]
      System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_ServerSendsInvalidSettingsValue_Error(settingId: MaxFrameSize, value: 16383, expectedError: PROTOCOL_ERROR) [FINISHED] Time: 0.6268973s
      System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_ServerSendsInvalidSettingsValue_Error(settingId: MaxFrameSize, value: 162777216, expectedError: PROTOCOL_ERROR) [STARTING]
      System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_ServerSendsInvalidSettingsValue_Error(settingId: MaxFrameSize, value: 162777216, expectedError: PROTOCOL_ERROR) [FINISHED] Time: 0.0191116s
      System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_ServerSendsInvalidSettingsValue_Error(settingId: InitialWindowSize, value: 2147483648, expectedError: FLOW_CONTROL_ERROR) [STARTING]
      System.Net.Http.Functional.Tests.SocketsHttpHandlerTest_Http2.Http2_ServerSendsInvalidSettingsValue_Error(settingId: InitialWindowSize, value: 2147483648, expectedError: FLOW_CONTROL_ERROR) [FINISHED] Time: 0.0115572s
    Finished:    System.Net.Http.Functional.Tests
  === TEST EXECUTION SUMMARY ===
     System.Net.Http.Functional.Tests  Total: 3, Errors: 0, Failed: 0, Skipped: 0, Time: 0.825s

fixes #1581
fixes https://github.com/dotnet/corefx/issues/35466

@wfurt wfurt added area-System.Net.Http test-bug Problem in test source code (most likely) labels Jan 24, 2020
@wfurt wfurt requested review from stephentoub and a team January 24, 2020 08:24
@wfurt wfurt self-assigned this Jan 24, 2020
ManickaP
ManickaP approved these changes Jan 24, 2020
View reviewed changes
Copy link
Member

@ManickaP ManickaP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tests are passing.

@wfurt
Copy link
Member Author

wfurt commented Jan 24, 2020

OSX failures in System.Threading.Tasks.Tests are unrelated.

@wfurt wfurt merged commit cb1fc80 into dotnet:master Jan 24, 2020
@wfurt wfurt deleted the H2Setting branch January 24, 2020 19:42
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ManickaP ManickaP ManickaP approved these changes

@stephentoub stephentoub stephentoub approved these changes

Assignees

@wfurt wfurt

Labels
area-System.Net.Http test-bug Problem in test source code (most likely)
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Reenable Http2_ServerSendsInvalidSettingsValue_Error test
4 participants
@wfurt @stephentoub @ManickaP @karelz