Update Dotnet host for testing and add RuntimeFrameworkVersion to nca5.0 package testing #2290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
approved these changes
Jan 28, 2020
safern
added
the
NO-MERGE
|
We'll wait until we produce a new package using a newer docker container for alpine which we need for the tests in alpine arm64 to pass. |
safern
force-pushed
the
UpdateDotnetHost
branch
from
ea31f91 to
f551459
Compare
safern
removed
the
NO-MERGE
|
Failures are known, will go ahead and merge. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we accidentally removed RuntimeFrameworkVersion for our package testing: #445
Also, in #1723 (comment) @janvorli noticed that we are using a pretty old dotnet host.
cc: @ViktorHofer @ericstj @dagood