Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Enable restore for ref and src projects in libraries" #33437

Merged
merged 1 commit into from
Mar 10, 2020

Conversation

ViktorHofer
Copy link
Member

Reverts #33242 until we get a newer NuGet which cuts down the time the build spends inside the graph evaluation, drastically.

cc @ericstj

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to unblock revert

@ericstj
Copy link
Member

ericstj commented Mar 10, 2020

Lets make establish the right set of criteria to bring this change back. I think we need to consider: testing, perf, and developer experience.

@ViktorHofer ViktorHofer merged commit 73268c7 into master Mar 10, 2020
@ViktorHofer ViktorHofer deleted the revert-33242-RestorePhase2 branch March 10, 2020 20:33
@stephentoub
Copy link
Member

Thanks.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants