Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable restore for ref and src projects in libs #33553

Merged
merged 90 commits into from
Apr 6, 2020

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Mar 13, 2020

Second attempt of #33242

Fixes #29953
Contributes towards #31844

Changes

  • Use RestoreUseStaticGraphEvaluation which improves no-op restore by 10-15x down to 10-20 seconds.
  • .builds msbuild files renamed to .proj as RestoreUseStaticGraphEvaluation throws for non .proj files without an env var set.
  • Introducing subsets for libraries and mono and replacing -buildtests switch which was only working for libraries in favor of the subset switch -subset tests which works consistently.
  • Fixing the Microsoft.DotNet.CodeAnalysis analyzer which wasn't running and adding missing exclusions.
  • Separating restore and build phases in different parts in the repo (ie for installer.tasks) as generated props and targets need to be imported which requires a reevaluation in the build phase.
  • Fix eng/docker/build-docker-sdk.ps1 by using the official build entrypoints (cc @alnikola)
  • Remove a few depprojs in favor of project restore (faster restore :))
  • Fix root code coverage measurement not working correctly
  • Traversal support instead of dir.traversal.targets or manual build target defines.
  • Introduce a root Build.proj entrypoint which is responsible for building and restoring the repository. This is necessary to enable the new NuGet fast restore which works best and fastest with a single entrypoint.
  • Avoid binclashes in libraries and between libraries and installer (netstandard.depproj vs netstandard.csproj)
  • Upgrading the SDK to 5.0 latest
  • Code cleanup

Perf

In most cases I see improvements in the overall restore but based on it hitting the network the numbers vary slightly accross builds. That said, this should provide confidence that the regression introduced in the previous attempt is now addressed.

Thoughts on the numbers:

  • Overall restore is either on parity or faster. This is because of a) a single entrypoint to restore and b) fast restore mode enabled.
  • No-op/Incremental restore is MUCH faster. Incremental restore takes up to 90% less time with NuGet Fast Restore Feature.
  • Libraries Test Builds should be noticeably faster in CI as it just restores what it needs.
Leg Build&Restore Before Build&Restore After
Mono Product Build Linux arm release 6m 55s 4m 45s
Mono Product Build Windows_NT x64 debug 4m 0s 3m 58s
Libraries Build Linux x64 Debug 12m 18s 12m 18s
Libraries Build OSX x64 Debug 8m 53s 9m 10s
Libraries Build Windows_NT x86 Release 15m 24s 13m 22s
Installer Build and Test Linux_musl_arm64 Debug 11m 52s 5m 34s
Installer Build and Test OSX_x64 Debug 8m 29s 8m 36s
Libraries Test Build Linux x64 Debug 8m 37s 7m 30s

Compared https://dev.azure.com/dnceng/public/_build/results?buildId=582003 with https://dev.azure.com/dnceng/public/_build/results?buildId=583335 and looked into other builds as well to make sure that the before numbers aren't a best or worst case.

cc @jeffkl @ericstj

@ViktorHofer ViktorHofer changed the title Enable restore for ref and src projects in libs #2 Enable restore for ref and src projects in libs Mar 23, 2020
@ViktorHofer ViktorHofer marked this pull request as ready for review March 23, 2020 20:20
@ViktorHofer ViktorHofer requested review from ericstj and Anipik and removed request for marek-safar, steveisok, EgorBo, akoeplinger and vargaz March 23, 2020 20:21
@ViktorHofer ViktorHofer self-assigned this Mar 23, 2020
NuGet.config Outdated Show resolved Hide resolved
global.json Outdated Show resolved Hide resolved
eng/Versions.props Outdated Show resolved Hide resolved
@ViktorHofer ViktorHofer force-pushed the RestorePhase2-respin branch from 0004237 to 3f7dab3 Compare March 26, 2020 20:10
@ViktorHofer
Copy link
Member Author

ViktorHofer commented Apr 4, 2020

@ViktorHofer
Copy link
Member Author

Failure is #30056

@ViktorHofer
Copy link
Member Author

Internal build succeeded and all previous public runs were green. Merging.

@ViktorHofer ViktorHofer merged commit 42183b1 into dotnet:master Apr 6, 2020
@ViktorHofer ViktorHofer deleted the RestorePhase2-respin branch April 6, 2020 09:54
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should test restore be part of build or build-tests?
10 participants