-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable restore for ref and src projects in libs #33553
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ViktorHofer
force-pushed
the
RestorePhase2-respin
branch
4 times, most recently
from
March 23, 2020 13:09
5d2c5c0
to
786b7d0
Compare
ViktorHofer
force-pushed
the
RestorePhase2-respin
branch
from
March 23, 2020 16:13
b0c5639
to
b92c5ee
Compare
ViktorHofer
commented
Mar 23, 2020
ViktorHofer
changed the title
Enable restore for ref and src projects in libs #2
Enable restore for ref and src projects in libs
Mar 23, 2020
ViktorHofer
requested review from
akoeplinger,
EgorBo,
marek-safar,
steveisok and
vargaz
as code owners
March 23, 2020 20:20
ViktorHofer
requested review from
ericstj and
Anipik
and removed request for
marek-safar,
steveisok,
EgorBo,
akoeplinger and
vargaz
March 23, 2020 20:21
Anipik
reviewed
Mar 24, 2020
Anipik
reviewed
Mar 24, 2020
ViktorHofer
force-pushed
the
RestorePhase2-respin
branch
from
March 25, 2020 13:13
307bf7b
to
2a00c2c
Compare
akoeplinger
reviewed
Mar 26, 2020
ViktorHofer
force-pushed
the
RestorePhase2-respin
branch
from
March 26, 2020 20:10
0004237
to
3f7dab3
Compare
eerhardt
reviewed
Apr 4, 2020
...Microsoft.Extensions.DependencyModel/tests/Microsoft.Extensions.DependencyModel.Tests.csproj
Show resolved
Hide resolved
Queued an official build: https://dnceng.visualstudio.com/internal/_build/results?buildId=589912 |
Failure is #30056 |
Internal build succeeded and all previous public runs were green. Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second attempt of #33242
Fixes #29953
Contributes towards #31844
Changes
-buildtests
switch which was only working for libraries in favor of the subset switch-subset tests
which works consistently.Perf
In most cases I see improvements in the overall restore but based on it hitting the network the numbers vary slightly accross builds. That said, this should provide confidence that the regression introduced in the previous attempt is now addressed.
Thoughts on the numbers:
Compared https://dev.azure.com/dnceng/public/_build/results?buildId=582003 with https://dev.azure.com/dnceng/public/_build/results?buildId=583335 and looked into other builds as well to make sure that the before numbers aren't a best or worst case.
cc @jeffkl @ericstj