Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JIT: propagate block flags during guarded devirt transform #33724

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

AndyAyersMS
Copy link
Member

This transform duplicates code that might contain constructs we track via
block flags, so update the block flags.

This transform duplicates code that might contain constructs we track via
block flags, so update the block flags.
@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Mar 18, 2020
@AndyAyersMS
Copy link
Member Author

@erozenfeld PTAL
cc @dotnet/jit-contrib

Copy link
Member

@erozenfeld erozenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AndyAyersMS
Copy link
Member Author

Addresses failures that were seen in the new jit-experimental test leg (see #33709).

@AndyAyersMS AndyAyersMS merged commit f7a6f0c into dotnet:master Mar 18, 2020
@AndyAyersMS AndyAyersMS deleted the FixGuardedDevirt branch March 18, 2020 20:32
@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants