Remove erroneous curlies in Xml resource #33890

Merged

danmoseley merged 33 commits intodotnet:masterfrom mrj001:Issue30218

Apr 18, 2020

+930-14

Commits on Apr 15, 2020

Added test for Issue 30218, use of resource Sch_MinLengthGtBaseMinLength
mrj001
committed
Reworded error message to remove the invalid formatters.
mrj001
committed
Updated check of message from the exception to be more amenable to potential internationalization.
mrj001
committed
Reworded resource Sch_MaxLengthGtBaseMaxLength and added unit test for same.
mrj001
committed
Simplified test code per feedback from Dan Moseley, PR#33890.
mrj001
committed
Tests to increase code coverage. The ones that are failing trigger resource string Sch_MaxMinLengthBaseLength to be used as the Exception message.
mrj001
committed
Removed invalid formatters from the resource string Sch_MaxMinLengthBaseLength. Failing tests from the previous commit now pass.
mrj001
committed
Added test for the Exception using string resource Sch_LengthGtBaseLength as its message. This covers a source line and branch not previously covered. This test fails due to the invalid formatters.
mrj001
committed
Reworded string resource Sch_LengthGtBaseLength to remove the invalid formatters.
mrj001
committed
Added unit tests for uses of string resource Sch_FacetBaseFixed.
mrj001
committed
Made test for the message containing "fixed" more specific.
mrj001
committed
Reworded string resource Sch_FacetBaseFixed to remove the invalid formatter.
mrj001
committed
Added unit test to cover usage of string resource Sch_InvalidAllMax. A second usage of this string resource is not covered as it is in a class marked Obsolete.
mrj001
committed
Reworded string resource Sch_InvalidAllMax to remove the invalid formatter.
mrj001
committed
Added unit test for String Resource Sch_InvalidAllElementMax - invalid formatter.
mrj001
committed
Reworded string resource Sch_InvalidAllElementMax to remove the invalid formatter.
mrj001
committed
Added unit test which causes an XmlSchemaException using string resource Sch_InvalidExemplar as its message.
mrj001
committed
Reworded Sch_InvalidExemplar to remove the invalid formatter. Also, added the name of the element which cannot be used as the substitution group affiliation.
mrj001
committed
Added unit test that causes an XmlSchemaException to be thrown using string resource Sch_GroupBaseRestNotEmptiable as its message.
mrj001
committed
Removed the curly braces so there are no longer any invalid formatters.
mrj001
committed
Added unit tests that cause an XmlSchemaException to be thrown using string resource Sch_AllRefMinMax as its message.
mrj001
committed
Changed string resource Sch_AllRefMinMax to remove the invalid formatters.
mrj001
committed
reworded Sch_MinLengthGtBaseMinLength and Sch_MaxLengthGtBaseMaxLength similarly to Sch_LengthGtBaseLength
mrj001
committed
Corrected error "greater than" to "less than".
mrj001
committed
Changed name of test to more accurately reflect its purpose.
mrj001
committed
Changed casing of MinLength and MaxLength to match their XML facets. Removed redundant ToLower call and comment.
mrj001
committed
Removed all Regex used to find invalid formatters.
mrj001
committed
renamed MaxMinLengthBaseLength_TestData to indicate that this is testing the successful case.
mrj001
committed
Removed suppression of exception so that we will see the exception if one is thrown.
mrj001
committed
Removed comments as there are issues tracking these.
mrj001
committed
Fixed comment larger -> lower.
mrj001
committed
Removed XML comments on test methods.
mrj001
committed
Removal of XML comment that was missed.
mrj001
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove erroneous curlies in Xml resource #33890

Commits on Apr 15, 2020

Added test for Issue 30218, use of resource Sch_MinLengthGtBaseMinLength

Reworded error message to remove the invalid formatters.

Updated check of message from the exception to be more amenable to potential internationalization.

Reworded resource Sch_MaxLengthGtBaseMaxLength and added unit test for same.

Simplified test code per feedback from Dan Moseley, PR#33890.

Tests to increase code coverage. The ones that are failing trigger resource string Sch_MaxMinLengthBaseLength to be used as the Exception message.

Removed invalid formatters from the resource string Sch_MaxMinLengthBaseLength. Failing tests from the previous commit now pass.

Added test for the Exception using string resource Sch_LengthGtBaseLength as its message. This covers a source line and branch not previously covered. This test fails due to the invalid formatters.

Reworded string resource Sch_LengthGtBaseLength to remove the invalid formatters.

Added unit tests for uses of string resource Sch_FacetBaseFixed.

Made test for the message containing "fixed" more specific.

Reworded string resource Sch_FacetBaseFixed to remove the invalid formatter.

Added unit test to cover usage of string resource Sch_InvalidAllMax. A second usage of this string resource is not covered as it is in a class marked Obsolete.

Reworded string resource Sch_InvalidAllMax to remove the invalid formatter.

Added unit test for String Resource Sch_InvalidAllElementMax - invalid formatter.

Reworded string resource Sch_InvalidAllElementMax to remove the invalid formatter.

Added unit test which causes an XmlSchemaException using string resource Sch_InvalidExemplar as its message.

Reworded Sch_InvalidExemplar to remove the invalid formatter. Also, added the name of the element which cannot be used as the substitution group affiliation.

Added unit test that causes an XmlSchemaException to be thrown using string resource Sch_GroupBaseRestNotEmptiable as its message.

Removed the curly braces so there are no longer any invalid formatters.

Added unit tests that cause an XmlSchemaException to be thrown using string resource Sch_AllRefMinMax as its message.

Changed string resource Sch_AllRefMinMax to remove the invalid formatters.

reworded Sch_MinLengthGtBaseMinLength and Sch_MaxLengthGtBaseMaxLength similarly to Sch_LengthGtBaseLength

Corrected error "greater than" to "less than".

Changed name of test to more accurately reflect its purpose.

Changed casing of MinLength and MaxLength to match their XML facets. Removed redundant ToLower call and comment.

Removed all Regex used to find invalid formatters.

renamed MaxMinLengthBaseLength_TestData to indicate that this is testing the successful case.

Removed suppression of exception so that we will see the exception if one is thrown.

Removed comments as there are issues tracking these.

Fixed comment larger -> lower.

Removed XML comments on test methods.

Removal of XML comment that was missed.