Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JsonIgnoreCondition & per-property ignore logic #34049

Merged
merged 2 commits into from
Mar 26, 2020

Conversation

layomia
Copy link
Contributor

@layomia layomia commented Mar 25, 2020

Fixes #30687.

@layomia layomia added this to the 5.0 milestone Mar 25, 2020
@layomia layomia requested a review from ahsonkhan as a code owner March 25, 2020 00:36
@layomia layomia self-assigned this Mar 25, 2020
@Dotnet-GitSync-Bot
Copy link
Collaborator

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ahsonkhan
Copy link
Member

cc @CodeBlanch

@layomia layomia merged commit c653291 into dotnet:master Mar 26, 2020
@layomia layomia deleted the per_property_ignore branch March 26, 2020 21:10
Copy link
Member

@jozkee jozkee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few questions but overall; looks good.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Text.Json ignore only when null API enhancement
5 participants