Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Console.Unix: avoid deadlock between LazyInitializer and Console.Out #34297

Merged
merged 32 commits into from
Apr 13, 2020
Merged

Console.Unix: avoid deadlock between LazyInitializer and Console.Out #34297

merged 32 commits into from
Apr 13, 2020

Commits on Mar 30, 2020

  1. Console.Unix: avoid deadlock between LazyInitializer and Console.Out

    @tmds
    tmds committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    d0f5dc1 View commit details
    Browse the repository at this point in the history

  2. Add assert for InternalSyncObject

    @tmds
    tmds committed Mar 30, 2020
    Configuration menu
    Copy the full SHA
    fae6ccb View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2020

  1. Console: use Interlocked for lazy initialization

    @tmds
    tmds committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    1ff6d97 View commit details
    Browse the repository at this point in the history

  2. Cleanup unused 'using'

    @tmds
    tmds committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    69473a8 View commit details
    Browse the repository at this point in the history

  3. Limit locking to event handlers

    @tmds
    tmds committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    d2b4e91 View commit details
    Browse the repository at this point in the history

  4. Fix AllowNull -> NotNull

    @tmds
    tmds committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    c4c09c2 View commit details
    Browse the repository at this point in the history

  5. Localize LazyInitializer.EnsureInitialized logic

    @tmds
    tmds committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    7de5274 View commit details
    Browse the repository at this point in the history

  6. Remove lazy initialize delegates

    @tmds
    tmds committed Mar 31, 2020
    Configuration menu
    Copy the full SHA
    af57dde View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2020

  1. Use static local functions for initializing

    @tmds
    tmds committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    d5bf05f View commit details
    Browse the repository at this point in the history

  2. Remove unused EnsureInitializedDisposableCore

    @tmds
    tmds committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    2043770 View commit details
    Browse the repository at this point in the history

  3. Remove unused arg from EnsureInitializedStdInReader

    @tmds
    tmds committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    008d833 View commit details
    Browse the repository at this point in the history

  4. Also EnsureInitialize when not redirected

    @tmds
    tmds committed Apr 1, 2020
    Configuration menu
    Copy the full SHA
    8e0b37f View commit details
    Browse the repository at this point in the history

Commits on Apr 2, 2020

  1. Dispose Console Streams with their Reader/Writer

    @tmds
    tmds committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    dc533a7 View commit details
    Browse the repository at this point in the history

  2. Fix s_out -> s_error

    @tmds
    tmds committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    3080288 View commit details
    Browse the repository at this point in the history

  3. leaveOpen streams, fix Encoding set race

    @tmds
    tmds committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    77c2c2f View commit details
    Browse the repository at this point in the history

  4. Fix races between Encoding en initializers of In/Out/Error

    @tmds
    tmds committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    0f48a86 View commit details
    Browse the repository at this point in the history

  5. Remove EnsureInitialized

    @tmds
    tmds committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    f4656f0 View commit details
    Browse the repository at this point in the history

  6. Cleanup

    @tmds
    tmds committed Apr 2, 2020
    Configuration menu
    Copy the full SHA
    73d24c4 View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2020

  1. Rename static local initializer functions to EnsureInitialized

    @tmds
    tmds committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    5b1f471 View commit details
    Browse the repository at this point in the history

  2. Use lock in Input/OutputEncoding

    @tmds
    tmds committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    3500753 View commit details
    Browse the repository at this point in the history

  3. Rename InternalSyncObject to s_syncObject

    @tmds
    tmds committed Apr 3, 2020
    Configuration menu
    Copy the full SHA
    614f621 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2020

  1. Cleanup space

    @tmds
    tmds committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    1fe70bd View commit details
    Browse the repository at this point in the history

  2. Fix _isStdErrRedirected -> _isStdInRedirected

    @tmds
    tmds committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    10ae846 View commit details
    Browse the repository at this point in the history

  3. Remove space

    @tmds
    tmds committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    f07e5ce View commit details
    Browse the repository at this point in the history

  4. Improve comments

    @tmds
    tmds committed Apr 6, 2020
    Configuration menu
    Copy the full SHA
    dcf7116 View commit details
    Browse the repository at this point in the history

Commits on Apr 7, 2020

  1. Fix potential CancelKeyPress deadlock

    @tmds
    tmds committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    b61ee9c View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-Authored-By: Stephen Toub <stoub@microsoft.com>
    @tmds @stephentoub
    tmds and stephentoub authored Apr 7, 2020
    Configuration menu
    Copy the full SHA
    705b104 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary null forgiving

    @tmds
    tmds committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    33d5b5c View commit details
    Browse the repository at this point in the history

  4. Add comment about why we're not Disposing StdInReader

    @tmds
    tmds committed Apr 7, 2020
    Configuration menu
    Copy the full SHA
    61349ef View commit details
    Browse the repository at this point in the history

Commits on Apr 8, 2020

  1. Add Volatile.Writes for Volatile.Read fields

    @tmds
    tmds committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    f19a34b View commit details
    Browse the repository at this point in the history

  2. More Volatile.Writes

    @tmds
    tmds committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    f009a74 View commit details
    Browse the repository at this point in the history

  3. Add back lock to SetIn

    @tmds
    tmds committed Apr 8, 2020
    Configuration menu
    Copy the full SHA
    a633fdc View commit details
    Browse the repository at this point in the history