Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial addition of tvOS Mono #34475

Merged
merged 40 commits into from
Apr 8, 2020
Merged

Initial addition of tvOS Mono #34475

merged 40 commits into from
Apr 8, 2020

Conversation

directhex
Copy link
Member

Let's see if this works

src/mono/mono.proj Outdated Show resolved Hide resolved
src/mono/mono.proj Outdated Show resolved Hide resolved
eng/native/configureplatform.cmake Outdated Show resolved Hide resolved
eng/native/configureplatform.cmake Outdated Show resolved Hide resolved
src/libraries/Directory.Build.props Outdated Show resolved Hide resolved
src/libraries/OSGroups.json Show resolved Hide resolved
eng/native/configureplatform.cmake Outdated Show resolved Hide resolved
src/mono/mono.proj Outdated Show resolved Hide resolved
@directhex directhex marked this pull request as ready for review April 6, 2020 20:10
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, only a few changes to address :)

eng/Subsets.props Show resolved Hide resolved
src/libraries/Native/Unix/CMakeLists.txt Show resolved Hide resolved
src/libraries/Native/Unix/configure.cmake Outdated Show resolved Hide resolved
src/libraries/Native/build-native.sh Outdated Show resolved Hide resolved
src/mono/mono.proj Show resolved Hide resolved
src/mono/mono.proj Show resolved Hide resolved
src/mono/mono.proj Outdated Show resolved Hide resolved
Copy link
Member

@akoeplinger akoeplinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, looks good otherwise!

src/mono/mono.proj Outdated Show resolved Hide resolved
@akoeplinger akoeplinger merged commit 952eeca into dotnet:master Apr 8, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants