Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't notify crossgen2 about Vector<T> size when not needed #34614

Merged
merged 1 commit into from
Apr 30, 2020
Merged

Don't notify crossgen2 about Vector<T> size when not needed #34614

merged 1 commit into from
Apr 30, 2020

Conversation

davidwrighton
Copy link
Member

  • Stop notifying about usage status of AVX2 when using isSubRegisterSIMDType
  • This allows use of the Vector2/3/4 simd types in crossgen'd code without fixing whether or not Avx2 is required

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 6, 2020
@davidwrighton
Copy link
Member Author

@CarolEidt This is the issue I fixed conservatively before checking in my large hardware instrinsics pr(#33274 ).

CarolEidt
CarolEidt approved these changes Apr 7, 2020
View reviewed changes
Copy link
Contributor

@CarolEidt CarolEidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidwrighton
Don't notify crossgen2 about Vector<T> size when not needed
51a0fab 
- Stop notifying  about usage status of AVX2 when using isSubRegisterSIMDType
- This allows use of the Vector2/3/4 simd types in crossgen'd code without fixing whether or not Avx2 is required
@davidwrighton davidwrighton force-pushed the moreOpportunisticHandlingOfSubRegisterOps branch from 2eda040 to 51a0fab Compare April 30, 2020 05:00
@davidwrighton
Copy link
Member Author

I held off on checking this in waiting for good crossgen2 CI infrastructure to be put together. Now that we have it, its clear that the fix is good, and I'm checking in.

@davidwrighton davidwrighton merged commit 71f84aa into dotnet:master Apr 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
@davidwrighton davidwrighton deleted the moreOpportunisticHandlingOfSubRegisterOps branch April 20, 2021 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CarolEidt CarolEidt CarolEidt approved these changes

Assignees
No one assigned
Labels
area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidwrighton @CarolEidt @Dotnet-GitSync-Bot