-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Guard against (de)serializing pointers & ref structs #34777
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
reviewed
Apr 9, 2020
steveharter
reviewed
Apr 9, 2020
src/libraries/System.Text.Json/tests/Serialization/InvalidTypeTests.cs
Outdated
Show resolved
Hide resolved
steveharter
reviewed
Apr 9, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.Cache.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Apr 20, 2020
stephentoub
reviewed
Apr 20, 2020
stephentoub
reviewed
Apr 20, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.cs
Show resolved
Hide resolved
stephentoub
reviewed
Apr 20, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.cs
Show resolved
Hide resolved
ahsonkhan
reviewed
Apr 22, 2020
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonClassInfo.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
reviewed
Apr 22, 2020
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
Show resolved
Hide resolved
ahsonkhan
reviewed
Apr 22, 2020
ahsonkhan
reviewed
Apr 22, 2020
src/libraries/System.Text.Json/src/System/Text/Json/ThrowHelper.Serialization.cs
Outdated
Show resolved
Hide resolved
steveharter
approved these changes
Apr 27, 2020
Test failure unrelated. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #34644.
Ref structs are explicitly not supported for deserialization following this PR; created an issue to consider support in the future - #34779. Prior to this change we leak a
TypeLoadException
: