Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix pal_io.c code based on code review suggestions #34970

Merged
merged 1 commit into from
Apr 15, 2020
Merged

Fix pal_io.c code based on code review suggestions #34970

merged 1 commit into from
Apr 15, 2020

Conversation

omajid
Copy link
Member

@omajid omajid commented Apr 14, 2020

These suggestions were provided by @lpereira on dotnet/corefx#42900

@ghost
Copy link

ghost commented Apr 14, 2020

Tagging subscribers to this area: @carlossanlop
Notify danmosemsft if you want to be subscribed.

stephentoub
stephentoub approved these changes Apr 14, 2020
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@stephentoub stephentoub merged commit 42c39c4 into dotnet:master Apr 15, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

Assignees
No one assigned
Labels
area-System.IO
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@omajid @stephentoub @Dotnet-GitSync-Bot