Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove passing tests from exclude list #35139

Merged
merged 1 commit into from
Apr 20, 2020

Conversation

fanyang-mono
Copy link
Member

Two tests used to fail is passing now.
Fixes #34391
Fixes #34380

@ghost
Copy link

ghost commented Apr 17, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@fanyang-mono fanyang-mono added area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI area-Codegen-JIT-mono and removed area-Infrastructure labels Apr 17, 2020
@ghost
Copy link

ghost commented Apr 17, 2020

Tagging subscribers to this area: @lewurm
Notify danmosemsft if you want to be subscribed.

@CoffeeFlux CoffeeFlux removed the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 19, 2020
Copy link
Contributor

@CoffeeFlux CoffeeFlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we know what commit fixed this?

We might want to wait until Nathan's CI PR goes in unless we know what fixed this or are sure it passes on all platforms. cc: @naricc

@CoffeeFlux
Copy link
Contributor

Also, please try to make sure only one label is applied or else it will cause issues with the bot.

@fanyang-mono
Copy link
Member Author

fanyang-mono commented Apr 20, 2020

These two tests were fixed by 7e73931

@fanyang-mono
Copy link
Member Author

Do we know what commit fixed this?

We might want to wait until Nathan's CI PR goes in unless we know what fixed this or are sure it passes on all platforms. cc: @naricc

I've talked to Nathan, these issues were generated out of the results from his macOS run. He hadn't run coreclr tests on other platforms before. So I think we could treat these issues are for macOS only. Additionally, without removing it from the exclude list, tests won't run on CI, after Nathan enables them on CI. Thus, I think we should removing passing tests from exclude list. If they ever fail again on CI, new issues should be created with probably new failure syndromes.

Copy link
Contributor

@CoffeeFlux CoffeeFlux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we know what commit fixed them and we're only concerned about OSX for now, then this looks great, thanks!

@naricc
Copy link
Contributor

naricc commented Apr 20, 2020

Yeah, go ahead and merge this. I will be enabling CI this week, if they crop up again on other architectures I will sort it out (re add them and create new issues).

@fanyang-mono fanyang-mono merged commit 8675bc4 into dotnet:master Apr 20, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants