-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove passing tests from exclude list #35139
Remove passing tests from exclude list #35139
Conversation
Tagging subscribers to this area: @ViktorHofer |
Tagging subscribers to this area: @lewurm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know what commit fixed this?
We might want to wait until Nathan's CI PR goes in unless we know what fixed this or are sure it passes on all platforms. cc: @naricc
Also, please try to make sure only one label is applied or else it will cause issues with the bot. |
These two tests were fixed by 7e73931 |
I've talked to Nathan, these issues were generated out of the results from his macOS run. He hadn't run coreclr tests on other platforms before. So I think we could treat these issues are for macOS only. Additionally, without removing it from the exclude list, tests won't run on CI, after Nathan enables them on CI. Thus, I think we should removing passing tests from exclude list. If they ever fail again on CI, new issues should be created with probably new failure syndromes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we know what commit fixed them and we're only concerned about OSX for now, then this looks great, thanks!
Yeah, go ahead and merge this. I will be enabling CI this week, if they crop up again on other architectures I will sort it out (re add them and create new issues). |
Two tests used to fail is passing now.
Fixes #34391
Fixes #34380