Enable DnsGetHostEntry_LocalHost_ReturnsFqdnAndLoopbackIPs #35399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/ncl |
aik-jahoda
approved these changes
Apr 24, 2020
MihaZupan
approved these changes
Apr 24, 2020
stephentoub
approved these changes
Apr 24, 2020
|
Why are we re-enabling this test? The PR doesn't say why. Was this just an isolated problem (infrastructure) and now it's ok? |
|
@davidsh Yes, that's correct. It was explained in the linked issue. |
Thanks. I'd like to suggest that a summary of the reason be included directly in these PRs. That will help avoid multiple clicks to understand a PR during review. |
alnikola
deleted the
alnikola/34317-enable-returns-fqdn-and-loopback-ips
branch
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test is enabled because the failures were caused by Helix infra issue (a misconfigured agent) which was fixed a couple of days ago.
Fixes #34317