Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coreclr Test570 due to ICU on Windows feature #35435

Merged
merged 4 commits into from
Apr 25, 2020

Conversation

safern
Copy link
Member

@safern safern commented Apr 25, 2020

Fixes: #35039

@ghost
Copy link

ghost commented Apr 25, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@safern
Copy link
Member Author

safern commented Apr 25, 2020

/azp run runtime-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines could not run because the pipeline triggers exclude this branch/path.

@safern
Copy link
Member Author

safern commented Apr 25, 2020

@GrabYourPitchforks
Copy link
Member

I reviewed the "build 18362" part of the change and confirmed that it matches the 19H1 RTM build. So there's my minor contribution. :)

@safern
Copy link
Member Author

safern commented Apr 25, 2020

I reviewed the "build 18362" part of the change

Thanks 😄

@jkotas
Copy link
Member

jkotas commented Apr 25, 2020

It would be better to fix this by moving the test to live under libraries where it belongs.

@jkotas
Copy link
Member

jkotas commented Apr 25, 2020

If we have appropriate coverage under libraries, just delete the test.

@safern
Copy link
Member Author

safern commented Apr 25, 2020

We already test this in Libraries:

yield return new object[] { CultureInfo.GetCultureInfo("en-US").NumberFormat, 2, 3 };

It seems like for PercentDecimalDigits we don't have such test case:
https://github.com/dotnet/runtime/blob/4f9ae42d861fcb4be2fcd5d3d55d5f227d30e723/src/libraries/System.Globalization/tests/NumberFormatInfo/NumberFormatInfoPercentDecimalDigits.cs

I guess I can just delete this test and add a test case in NumberFormatInfoPercentDecimalDigits tests

@safern
Copy link
Member Author

safern commented Apr 25, 2020

Updated to remove the test and add the missing test data in libraries test.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jkotas
Copy link
Member

jkotas commented Apr 25, 2020

The test failures are issues #35452 #35438 #35451

@jkotas jkotas merged commit 1db71ea into dotnet:master Apr 25, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test failure: Regressions\\coreclr\\0570\\Test570\\Test570.cmd
5 participants