-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coreclr Test570 due to ICU on Windows feature #35435
Conversation
Tagging subscribers to this area: @ViktorHofer |
/azp run runtime-coreclr outerloop |
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
I queued a build from this branch: https://dev.azure.com/dnceng/public/_build/results?buildId=616798&view=results |
I reviewed the "build 18362" part of the change and confirmed that it matches the 19H1 RTM build. So there's my minor contribution. :) |
Thanks 😄 |
It would be better to fix this by moving the test to live under libraries where it belongs. |
If we have appropriate coverage under libraries, just delete the test. |
We already test this in Libraries: Line 15 in 1db45ed
It seems like for PercentDecimalDigits we don't have such test case: I guess I can just delete this test and add a test case in NumberFormatInfoPercentDecimalDigits tests |
Updated to remove the test and add the missing test data in libraries test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Fixes: #35039