Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete redundant CoreCLR regression tests #35437

Merged
merged 2 commits into from
Apr 25, 2020
Merged

Delete redundant CoreCLR regression tests #35437

merged 2 commits into from
Apr 25, 2020

Conversation

jkotas
Copy link
Member

@jkotas jkotas commented Apr 25, 2020 •
edited
Loading

Fixes #35045

@ghost
Copy link

ghost commented Apr 25, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@jkotas jkotas requested a review from danmoseley April 25, 2020 03:46
@jkotas
Copy link
Member Author

jkotas commented Apr 25, 2020

All these tests have equivalent coverage either under libraries or under coreclr (number of them are exact duplicates of other tests).

@danmoseley
Copy link
Member

AssemblyNameTests.cs(399,20): error CS1501: No overload for method 'Equal' takes 1 arguments

@jkotas
Copy link
Member Author

jkotas commented Apr 25, 2020

Test failures are known issue #35438

@jkotas jkotas merged commit b6a5c31 into dotnet:master Apr 25, 2020
@jkotas jkotas deleted the issue-35045 branch April 25, 2020 07:21
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danmoseley danmoseley danmoseley approved these changes

Assignees
No one assigned
Labels
area-Meta
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove redundant coreclr regression tests
3 participants
@jkotas @danmoseley @Dotnet-GitSync-Bot