Conversation
|
The actual build is not setup yet. |
eng/liveBuilds.targets
Outdated
There was a problem hiding this comment.
I think wasm name is redundant in this context and it might be better to explicitly included as there is only a handful of files
There was a problem hiding this comment.
The different kinds of files go to different places inside the nuget, so they need different property names.
There was a problem hiding this comment.
I was referring to \wasm\runtimes not sure we need this if the package is wasm only
There was a problem hiding this comment.
hm yeah it's a bit redundant but since this is the source directory where the files get picked up rather than the destination in the nuget I don't care too much here.
There was a problem hiding this comment.
Nit: Shouldn't we be using Condition="'$(TargetsBrowser)' == 'true'" here instead of Condition="'$(TargetOS)' == 'Browser'" for consistency?
There was a problem hiding this comment.
Ideally yes, but that can be cleaned up later.
vargaz
force-pushed
the
wasm-runtime
branch
2 times, most recently
from
a92b9c9 to
c371e7c
Compare
vargaz
force-pushed
the
wasm-runtime
branch
3 times, most recently
from
0f58684 to
cca8a28
Compare
|
The wasm installer build needs EMSDK_PATH set as well. |
vargaz
force-pushed
the
wasm-runtime
branch
5 times, most recently
from
e681a00 to
d3f2741
Compare
|
This seems to work now. |
|
@akoeplinger please review |
eng/liveBuilds.targets
Outdated
There was a problem hiding this comment.
hm yeah it's a bit redundant but since this is the source directory where the files get picked up rather than the destination in the nuget I don't care too much here.
There was a problem hiding this comment.
the wasm/runtimes in the path is redundant
…h to the make dependencies.
…ks might not exist yet.
ghost
locked as resolved and limited conversation to collaborators
6 participants
No description provided.