Make H3StaticTable class static

[Youssef1313]

No description provided.

[ghost]

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

[Youssef1313]

The indexers aren't allowed in static class. I tried to check if it was used any where but found none. However, I can't confirm because I run into build problems on my machine, so I'll wait for the CI build to finish and check.

[Tratcher]

This is going to require a matching PR in AspNetCore as well.
https://github.com/dotnet/runtime/blob/3688c871daeecc9a208f12eff0ae1a876bb6b947/src/libraries/Common/src/System/Net/Http/aspnetcore/ReadMe.SharedCode.md

[Youssef1313]

This is going to require a matching PR in AspNetCore as well.
https://github.com/dotnet/runtime/blob/3688c871daeecc9a208f12eff0ae1a876bb6b947/src/libraries/Common/src/System/Net/Http/aspnetcore/ReadMe.SharedCode.md

Isn't this done automatically, just like dotnet/aspnetcore#20640?

[Tratcher]

Isn't this done automatically, just like dotnet/aspnetcore#20640?

That's a fail-safe to make sure we don't miss anything. We want to know changes compile and work in both repos before merging them in either. That said, this one's probably OK since it didn't change any of the API surface area consumed by HttpClient or Kestrel. We can auto-merge it when the tests pass.

[Youssef1313]

Isn't this done automatically, just like dotnet/aspnetcore#20640?

That's a fail-safe to make sure we don't miss anything. We want to know changes compile and work in both repos before merging them in either. That said, this one's probably OK since it didn't change any of the API surface area consumed by HttpClient or Kestrel. We can auto-merge it when the tests pass.

Ok, I'm going to create a similar PR in aspnetcore

[Youssef1313]

After giving a look, it won't actually compile correctly in aspnetcore 😆
The indexer wasn't used here, but was used there. That's the reason it existed.

Because indexers can't be used in static class, I'll have to make a method instead of the indexer. Should this method be included here also? (given that it's used only in aspnetnet repo but not here)

[Tratcher]

Should this method be included here also?

Yes, the shared files should match exactly. There's instructions in the readme for copying the files. You can develop the fix in either repo, but make sure to copy it when you're done.

[Youssef1313]

Should this method be included here also?

Yes, the shared files should match exactly. There's instructions in the readme for copying the files. You can develop the fix in either repo, but make sure to copy it when you're done.

Thanks for guidance, I'll fix it soon.

[Youssef1313]

I opened dotnet/aspnetcore#21705

[stephentoub]

All of these static fields should now be renamed to have an s_ rather than just _ prefix.

[Youssef1313]

@Tratcher @stephentoub The parallel PR (dotnet/aspnetcore#21705) is merged.

[ghost]

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

[stephentoub]

@Tratcher, should I merge this? Not sure how the mirror works.

[Tratcher]

@stephentoub yes please. Ideally we merge the changes into both repos on the same day and then the mirror doesn't have to do anything. It's only there as a failsafe.