Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naricc/ci interpreter arm64 #36258

Merged
merged 59 commits into from
May 17, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
59 commits
Select commit Hold shift + click to select a range
b90b291
Changes to issues.targets
Feb 11, 2020
425ccba
Changes to issues.targets
Feb 12, 2020
d9c6beb
Changes to build-test to exclude mono failures.
Feb 19, 2020
5b471cf
Added mono issues to issues.targets
Feb 20, 2020
83231f6
Merge branch 'master' of github.com:dotnet/runtime into naricc/core-r…
Feb 20, 2020
050628e
Merged issues.targets
Feb 20, 2020
13c0030
Merge branch 'master' of github.com:dotnet/runtime into naricc/core-r…
Feb 21, 2020
2c10658
Merge branch 'master' of github.com:dotnet/runtime into naricc/core-r…
Feb 21, 2020
daf690b
Updated build-test.sh
Feb 25, 2020
83631d8
Changed comparison
Feb 25, 2020
cd8acb6
Debugging changes.
Feb 25, 2020
fd55796
Debugging changes.
Feb 28, 2020
8bcefa8
Changes to support release/debug.
Mar 3, 2020
1914825
Fixed some issues.
Mar 3, 2020
1f75a84
Fixed some errors in issues.targets
Mar 3, 2020
85bc1eb
Updates to issues.targets.
Mar 4, 2020
f7f7147
More updates to issues.targets
Mar 4, 2020
e92a894
Removed debugging stuff from build-test.sh
Mar 4, 2020
31ea81c
Removed debugging Messages.
Mar 4, 2020
e85f52b
Removed commented out old code.
Mar 4, 2020
95e84a7
More commented out code.
Mar 4, 2020
336dbf1
Removed whitespace changes.
Mar 4, 2020
784c7be
Removed whitespace changes, again.
Mar 4, 2020
9187ade
Removed more debugging stuff
Mar 4, 2020
eead294
Changed name of build-test argument. Took out debug print.
Mar 4, 2020
5bdae9b
Changed command line argument.
Mar 4, 2020
0a8091e
Remvoed trailing whitespace.
Mar 4, 2020
6c62c94
Fixed indentation.
Mar 4, 2020
3daf44c
More indentation fixes.
Mar 4, 2020
aca3db7
Added exclusion that got deleted some how.
Mar 4, 2020
35a45c0
Removed trailing whitespace.
Mar 4, 2020
c06bd72
tests/issues.targets
Mar 4, 2020
6688c10
Merge branch 'master' of github.com:dotnet/runtime into naricc/core-r…
Mar 4, 2020
1f19046
Merged change from master.
Mar 12, 2020
a70110d
Merge branch 'master' of github.com:dotnet/runtime
Mar 16, 2020
4894f7b
Merge branch 'master' of github.com:dotnet/runtime
Mar 17, 2020
b6176ef
Merge branch 'master' of github.com:dotnet/runtime
Mar 19, 2020
8cceb68
Merge branch 'master' of github.com:dotnet/runtime
Mar 23, 2020
ac8dc17
Undid changes that shouldn't be in master.
Mar 23, 2020
3ef2fa2
Merge branch 'master' of github.com:dotnet/runtime
Apr 22, 2020
bba8fac
Merge branch 'master' of github.com:naricc/runtime
May 6, 2020
c664e43
Merge branch 'master' of github.com:dotnet/runtime
May 6, 2020
5ecf4f7
Merge branch 'master' of github.com:dotnet/runtime
May 8, 2020
287b9c7
Merge branch 'master' of github.com:dotnet/runtime
May 11, 2020
00fc9cc
Added mono-interpreter arm64 lane.
May 12, 2020
59971bf
Merge branch 'master' of github.com:dotnet/runtime into naricc/ci-int…
May 12, 2020
a045eae
Made interpreter a scenario isntead of a seperate leg.
May 14, 2020
f8eb5ec
Made interpreter a scenario isntead of a seperate leg.
May 14, 2020
bab8c5c
Fixed white space issue.
May 14, 2020
981bca3
Fixed missing -
May 14, 2020
8f486e6
Changed how we propagate interpreter flag.
May 15, 2020
663df27
Merge branch 'master' of github.com:dotnet/runtime into naricc/ci-int…
May 15, 2020
3a078c5
Removed interpreter check form run-test-job.
May 15, 2020
c9df8a6
Removed interpreter stuff from helixpublishwitharcade.
May 15, 2020
87780f6
Added interpreter failures to issues.targets.
May 15, 2020
5f118ed
Added missing part to paths in failed interpreter tests.
May 15, 2020
a1a6496
More interpreter issues.
May 15, 2020
f248e41
Added arm64 interpreter issues.
May 16, 2020
501f445
Added issues.targets.
May 16, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions eng/pipelines/common/templates/runtimes/run-test-job.yml
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,6 @@ jobs:
- name: crossgenArg
value: 'composite'

- ${{ if eq(parameters.runtimeMode, 'interpreter') }}:
- name: RuntimeModeDisplayName
value: 'Interpreter'

# Set job timeouts
#
# "timeoutPerTestCollectionInMinutes" is the time needed for the "biggest" xUnit test collection to complete.
Expand Down Expand Up @@ -335,7 +331,10 @@ jobs:
${{ if in(parameters.testGroup, 'innerloop', 'outerloop') }}:
scenarios:
- normal
- no_tiered_compilation
- ${{ if eq(parameters.runtimeFlavor, 'coreclr') }}:
- no_tiered_compilation
- ${{ if eq(parameters.runtimeFlavor, 'mono') }}:
- interpreter
${{ if in(parameters.testGroup, 'jitstress') }}:
scenarios:
- jitminopts
Expand Down
23 changes: 0 additions & 23 deletions eng/pipelines/runtime.yml
Original file line number Diff line number Diff line change
Expand Up @@ -729,29 +729,6 @@ jobs:
eq(dependencies.checkout.outputs['SetPathVars_runtimetests.containsChange'], true),
eq(variables['isFullMatrix'], true))
#
# Mono CoreCLR runtime Test executions using live libraries
# Only when Mono is changed
- template: /eng/pipelines/common/platform-matrix.yml
parameters:
jobTemplate: /eng/pipelines/common/templates/runtimes/run-test-job.yml
buildConfig: release
runtimeFlavor: mono
platforms:
- OSX_x64
helixQueueGroup: pr
helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml
jobParameters:
testGroup: innerloop
liveLibrariesBuildConfig: ${{ variables.debugOnPrReleaseOnRolling }}
liveRuntimeBuildConfig: release
runtimeMode: 'interpreter'
runtimeModeDisplayName: 'Interpreter'
condition: >-
or(
eq(dependencies.checkout.outputs['SetPathVars_mono.containsChange'], true),
eq(variables['isFullMatrix'], true))
#
# Libraries Release Test Execution against a release mono runtime.
# Only when libraries or mono changed
Expand Down
3 changes: 0 additions & 3 deletions src/coreclr/tests/helixpublishwitharcade.proj
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,6 @@
<TestRunNamePrefix Condition=" '$(RunCrossGen2)' == 'true' ">R2R-CG2 </TestRunNamePrefix>
<TestRunNamePrefix Condition=" '$(Scenario)' == 'normal' ">$(TestRunNamePrefix)$(TargetOS) $(TargetArchitecture) $(Configuration) @ </TestRunNamePrefix>
<TestRunNamePrefix Condition=" '$(Scenario)' != 'normal' ">$(TestRunNamePrefix)$(TargetOS) $(TargetArchitecture) $(Configuration) $(Scenario) @ </TestRunNamePrefix>
<TestRunNamePrefix Condition=" '$(RuntimeMode)' == 'interpreter' ">$(TestRunNamePrefix) Interpreter </TestRunNamePrefix>
<TimeoutPerTestInMilliseconds Condition=" '$(TimeoutPerTestInMinutes)' != '' ">$([System.TimeSpan]::FromMinutes($(TimeoutPerTestInMinutes)).TotalMilliseconds)</TimeoutPerTestInMilliseconds>
<WaitForWorkItemCompletion>true</WaitForWorkItemCompletion>
<_XUnitParallelMode>collections</_XUnitParallelMode>
Expand All @@ -224,7 +223,6 @@
<HelixPreCommand Include="set __CollectDumps=1" />
<HelixPreCommand Include="set __CrashDumpFolder=%HELIX_DUMP_FOLDER%" />
<HelixPreCommand Include="type %__TestEnv%" />
<HelixPreCommand Include="set MONO_ENV_OPTIONS='--interpreter'" Condition=" '$(RuntimeMode)' == 'interpreter' " />
</ItemGroup>

<ItemGroup Condition=" '$(TargetsWindows)' != 'true' ">
Expand All @@ -244,7 +242,6 @@
<HelixPreCommand Include="cat $__TestEnv" />
<HelixPreCommand Include="sudo bash -c 'echo $HELIX_DUMP_FOLDER/core.%u.%p > /proc/sys/kernel/core_pattern'" Condition=" '$(TargetOS)' != 'OSX' " />
<HelixPreCommand Include="ulimit -c unlimited" Condition=" '$(TargetOS)' == 'OSX' " />
<HelixPreCommand Include="export MONO_ENV_OPTIONS='--interpreter" Condition=" '$(RuntimeMode)' == 'interpreter' " />
</ItemGroup>

<PropertyGroup>
Expand Down
Loading