Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurations for SunOS in installer #36316

Merged
merged 1 commit into from
May 13, 2020
Merged

Add configurations for SunOS in installer #36316

merged 1 commit into from
May 13, 2020

Conversation

am11
Copy link
Member

@am11 am11 commented May 13, 2020

  • Add configurations for SunOS and NetBSD, aligns with FreeBSD.
  • Fix a build warning in a cmake elseif case.

Contributes to #34944.

@ghost
Copy link

ghost commented May 13, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@am11
Copy link
Member Author

am11 commented May 13, 2020

cc @janvorli, @jkotas

janvorli
janvorli approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@janvorli janvorli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@janvorli janvorli merged commit 5859dad into dotnet:master May 13, 2020
@am11 am11 deleted the feature/sunos/configurations branch May 13, 2020 21:58
@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@janvorli janvorli janvorli approved these changes

Assignees
No one assigned
Labels
area-Infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @janvorli @Dotnet-GitSync-Bot