Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsoft.Extensions.Caching.Memory.MemoryCache: Reduce DateTime.UtcNow calls #36775

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Microsoft.Extensions.Caching.Memory.MemoryCache: Reduce DateTime.UtcNow calls #36775

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d352fef
MemoryCache: Reduce DateTime.UtcNow calls
May 20, 2020
b57f0a1
Merge branch 'master' into craver/memorycache/utc-reuse
ericstj Jun 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/libraries/Microsoft.Extensions.Caching.Memory/src/MemoryCache.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ private void SetEntry(CacheEntry entry)
}
}

StartScanForExpiredItems();
StartScanForExpiredItems(utcNow);
}

/// <inheritdoc />
Expand Down Expand Up @@ -257,7 +257,7 @@ public bool TryGetValue(object key, out object result)
}
}

StartScanForExpiredItems();
StartScanForExpiredItems(utcNow);

return found;
}
Expand Down Expand Up @@ -306,9 +306,10 @@ private void EntryExpired(CacheEntry entry)

// Called by multiple actions to see how long it's been since we last checked for expired items.
// If sufficient time has elapsed then a scan is initiated on a background task.
private void StartScanForExpiredItems()
private void StartScanForExpiredItems(DateTimeOffset? utcNow = null)
{
DateTimeOffset now = _options.Clock.UtcNow;
// Since fetching time is expensive, minimize it in the hot paths
DateTimeOffset now = utcNow ?? _options.Clock.UtcNow;
if (_options.ExpirationScanFrequency < now - _lastExpirationScan)
{
_lastExpirationScan = now;
Expand Down