Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce ConcurrentDictionary.TryGetValue overhead #37081

Merged
merged 7 commits into from
May 28, 2020
Merged

Reduce ConcurrentDictionary.TryGetValue overhead #37081

merged 7 commits into from
May 28, 2020

Commits on May 28, 2020

  1. Clean up style in ConcurrentDictionary 

    No functional changes.
    @stephentoub
    stephentoub committed May 28, 2020
    Configuration menu
    Copy the full SHA
    b30abea View commit details
    Browse the repository at this point in the history

  2. Optimize ConcurrentDictionary for no comparer as well as value type keys

    @stephentoub
    stephentoub committed May 28, 2020
    Configuration menu
    Copy the full SHA
    e758a93 View commit details
    Browse the repository at this point in the history

  3. Special-case StringComparer.Ordinal in ConcurrentDictionary

    @stephentoub
    stephentoub committed May 28, 2020
    Configuration menu
    Copy the full SHA
    1901c22 View commit details
    Browse the repository at this point in the history

  4. Store repeatedly used fields into locals

    @stephentoub
    stephentoub committed May 28, 2020
    Configuration menu
    Copy the full SHA
    458f65f View commit details
    Browse the repository at this point in the history

  5. Use FastMod in ConcurrentDictionary

    @stephentoub
    stephentoub committed May 28, 2020
    Configuration menu
    Copy the full SHA
    dd4d1c8 View commit details
    Browse the repository at this point in the history

  6. Allow atomic writes of {U}IntPtr 

    From ECMA 335:
"The native size types (native int, native unsigned int, and &) are always naturally aligned (4 bytes or 8 bytes, depending on the architecture)"
and
"A conforming CLI shall guarantee that read and write access to properly aligned memory locations no larger than the native word size (the size of type native int) is atomic (see §I.12.6.2) when all the write accesses to a location are the same size. "
    @stephentoub
    stephentoub committed May 28, 2020
    Configuration menu
    Copy the full SHA
    32c0383 View commit details
    Browse the repository at this point in the history

  7. Address PR feedback

    @stephentoub
    stephentoub committed May 28, 2020
    Configuration menu
    Copy the full SHA
    45bd55d View commit details
    Browse the repository at this point in the history