-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PAL_IsDebuggerPresent for SunOS #37273
Conversation
Some of the remaining gcc warnings have explanation in code:
and all the rest are related to #33541. |
The PAL and PAL tests changes look good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor request
@am11 can you push an update (e.g., rebase to master) to force the tests to run again, and hope they don't have infrastructure failures? |
@BruceForstall, rebased to master. |
On illumos and Solaris, unlike Linux,
/proc/{pid}/status
does not:TracerPID:
when debugger is attachedInstead it returns data for
struct pstatus_t
.When the debugger is attached, the flags are set in
fltset_t pr_flttrace
field, wherefltset_t
is defined as a struct wrappingint word[4]
and it is described inproc(4)
as/* set of traced faults */
.I have tested it under the debugger and this (zero'th) index is always set.
Also:
Contributes to: #34944.