Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[browser][wasm] Fix JavaScript core object creation and interop binding. #37885

Merged
merged 1 commit into from
Jun 16, 2020
Merged

[browser][wasm] Fix JavaScript core object creation and interop binding. #37885

merged 1 commit into from
Jun 16, 2020

Conversation

kjpou1
Copy link
Contributor

@kjpou1 kjpou1 commented Jun 15, 2020

  • Missing parameter for ownsHandle.

Source of invalid cast exceptions.

@kjpou1 kjpou1 requested a review from marek-safar as a code owner June 15, 2020 05:11
@ghost
Copy link

ghost commented Jun 15, 2020

Tagging subscribers to this area: @ViktorHofer
Notify danmosemsft if you want to be subscribed.

@kjpou1 kjpou1 requested review from akoeplinger, vargaz, kg and lewing June 15, 2020 05:12
@kjpou1 kjpou1 closed this Jun 15, 2020
@kjpou1 kjpou1 reopened this Jun 15, 2020
@jaredpar jaredpar mentioned this pull request Jun 15, 2020
Closed
@kjpou1 kjpou1 merged commit bbb5902 into dotnet:master Jun 16, 2020
@kjpou1 kjpou1 deleted the wasm-interop-core-fix branch June 16, 2020 04:55
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@marek-safar marek-safar marek-safar approved these changes

@akoeplinger akoeplinger Awaiting requested review from akoeplinger

@vargaz vargaz Awaiting requested review from vargaz

@kg kg Awaiting requested review from kg

@lewing lewing Awaiting requested review from lewing

Assignees
No one assigned
Labels
arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kjpou1 @marek-safar @Dotnet-GitSync-Bot