ICU integration and asset loading overhaul #37971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kg
added
NO-MERGE
|
Tagging subscribers to this area: @ViktorHofer |
|
Not sure what happened to runtime-test.js... does it have weird git line ending attributes set? |
Probably just .editorconfig fixing bad whitespace. |
EgorBo
reviewed
Jun 25, 2020
EgorBo
reviewed
Jun 25, 2020
kg
force-pushed
the
icu-loader
branch
2 times, most recently
from
ec2e896
to
bcd4f0a
Compare
Checkpoint Checkpoint Checkpoint Checkpoint Maybe fix whitespace damage Fix missing line endings in mono-config.js Maybe fix whitespace damage Add verification and fail-fast errors if ICU build data is missing or in the wrong place Checkpoint Checkpoint Checkpoint Checkpoint Checkpoint Checkpoint Checkpoint Fix whitespace damage Add editorconfig file for the wasm files Checkpoint Fix typo Checkpoint Checkpoint Cleanup Cleanup Reverse accidental removal of invariant default Checkpoint Sensible error when ICU_REPO is not set Checkpoint: Reset changes for mangled files Manually repair rebase damage These changes are no longer needed Repair rebase damage Fix mode damage Address PR feedback Fix icushim being built in static mode Remove broken wildcard dependency Fix sample startup
# Conflicts: # src/libraries/tests.proj
tarekgh
reviewed
Jul 15, 2020
src/libraries/Native/Unix/System.Globalization.Native/pal_icushim_static.c
Show resolved
Hide resolved
lewing
reviewed
Jul 16, 2020
src/libraries/Common/src/Interop/Interop.TimeZoneInfo.Browser.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Jul 16, 2020
src/libraries/Common/src/Interop/Interop.TimeZoneInfo.Browser.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Jul 16, 2020
src/libraries/System.Globalization/tests/DateTimeFormatInfo/DateTimeFormatInfoTests.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Jul 16, 2020
src/libraries/System.Globalization/tests/System/Globalization/RegionInfoTests.cs
Outdated
Show resolved
Hide resolved
marek-safar
reviewed
Jul 16, 2020
marek-safar
reviewed
Jul 16, 2020
akoeplinger
reviewed
Jul 16, 2020
src/libraries/Common/src/Interop/Interop.TimeZoneInfo.Browser.cs
Outdated
Show resolved
Hide resolved
src/libraries/Native/Unix/System.Globalization.Native/pal_icushim_static.c
Outdated
Show resolved
Hide resolved
…him_static.c Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
marek-safar
reviewed
Jul 16, 2020
...braries/System.Private.CoreLib/src/System/TimeZoneInfo.Unix.TimeZoneDisplayName.Invariant.cs
Outdated
Show resolved
Hide resolved
99 tasks
lewing
approved these changes
Jul 16, 2020
safern
reviewed
Jul 16, 2020
| @@ -358,6 +358,7 @@ public void Load() | |||
| } | |||
|
|
|||
| [Fact] | |||
| [PlatformSpecific(~TestPlatforms.Browser)] | |||
safern
approved these changes
Jul 16, 2020
lewing
added a commit
to lewing/runtime
that referenced
this pull request
Jul 21, 2020
This PR overhauls runtime startup/asset loading and adds support for ICU integration.
The mono-config.js format is reworked and simplified, with new functionality added:
Individual assets can be loaded from one or more remote sources with configurable fallback behavior
In addition to the existing support for loading assemblies, you can now pre-load arbitrary files into the native heap or into emscripten's virtual file system. VFS support previously only existed in runtime-test.js but now is available to any consumer of dotnet.js.
Assets can have a virtual path set so that their application-facing path does not necessarily have to match their path on the server.
One or more ICU data archives can be added to the assets list and will be automatically loaded and used to enable ICU-based globalization support.
Many configuration knobs that previously required API calls can now be set declaratively in the configuration file (environment variables, etc.)
WasmAppBuilder is updated to add ICUDataFiles and RemoteSources parameters that can be used to add the associated information to the config file declaratively from a msbuild project.
Various adjustments are made to existing tests and test cases so that they will pass with the addition of ICU integration.
Co-authored-by: EgorBo <egorbo@gmail.com>
Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
Co-authored-by: Larry Ewing <lewing@microsoft.com>
lewing
added a commit
that referenced
this pull request
Jul 22, 2020
* ICU integration and asset loading overhaul (#37971) This PR overhauls runtime startup/asset loading and adds support for ICU integration. The mono-config.js format is reworked and simplified, with new functionality added: Individual assets can be loaded from one or more remote sources with configurable fallback behavior In addition to the existing support for loading assemblies, you can now pre-load arbitrary files into the native heap or into emscripten's virtual file system. VFS support previously only existed in runtime-test.js but now is available to any consumer of dotnet.js. Assets can have a virtual path set so that their application-facing path does not necessarily have to match their path on the server. One or more ICU data archives can be added to the assets list and will be automatically loaded and used to enable ICU-based globalization support. Many configuration knobs that previously required API calls can now be set declaratively in the configuration file (environment variables, etc.) WasmAppBuilder is updated to add ICUDataFiles and RemoteSources parameters that can be used to add the associated information to the config file declaratively from a msbuild project. Various adjustments are made to existing tests and test cases so that they will pass with the addition of ICU integration. Co-authored-by: EgorBo <egorbo@gmail.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com> Co-authored-by: Larry Ewing <lewing@microsoft.com> * [wasm] Include data archives and timezone data by default (#39586) * Add data archive loading to the generic loading logic * [mono] Update ICU version, disable some tests for Browser (#39596) Co-authored-by: Katelyn Gadd <kg@luminance.org> Co-authored-by: EgorBo <egorbo@gmail.com> Co-authored-by: Alexander Köplinger <alex.koeplinger@outlook.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR overhauls runtime startup/asset loading and adds support for ICU integration.
The mono-config.js format is reworked and simplified, with new functionality added:
WasmAppBuilder is updated to add
ICUDataFilesandRemoteSourcesparameters that can be used to add the associated information to the config file declaratively from a msbuild project.Various adjustments are made to existing tests and test cases so that they will pass with the addition of ICU integration.