Fix a Race in Installer Test Infrastructure #38143
Merged
+13
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StaticHostTest used the StaticHostApp (which is effectively a copy of StandaloneApp) as a work-around for synchronization problems. Remove this work-around.
|
Tagging subscribers to this area: @vitek-karas, @swaroop-sridhar |
vitek-karas
approved these changes
Jun 22, 2020
| @@ -67,25 +69,26 @@ public virtual void Dispose() | |||
| _copies.Clear(); | |||
| } | |||
|
|
|||
| private static readonly object pathCountLock = new object(); | |||
There was a problem hiding this comment.
Suggested change
| private static readonly object pathCountLock = new object(); | |
| private static readonly object _pathCountLock = new object(); |
Add locking around GetNewTestArtifactPath() so that multiple threads attempting to create new copies of a TextFixture don't collide and work on the same path.
|
Hello @swaroop-sridhar! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
ghost
merged commit 
ghost
locked as resolved and limited conversation to collaborators
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the following changes:
Fixes #33675
Fixes #38013