[wasm] Add assembly level ActiveIssue for System.Threading.Tasks.Dataflow #38470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tarekgh |
tarekgh
approved these changes
Jun 26, 2020
|
This is skipping half of the whole test suite. Is it really worth running the remaining half? Could someone reasonably use the library in this state? |
|
Good question. If the library isn't usable, we should throw PNSE. |
|
Are all of the tests being skipped because of a problem in the library, or are they being skipped because we don't support |
|
I believe it's due to |
|
yeah it should be due to async Task, I agree it's a bit much to disable 80% of the tests so we should probably skip this test library for now. |
mdh1418
force-pushed
the
mdhwang/skip_system_threading_tasks_dataflow_tests
branch
from
192c802 to
299937a
Compare
mdh1418
changed the title
steveisok
approved these changes
Jun 29, 2020
akoeplinger
approved these changes
Jun 29, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When disabling tests with
async Task, about half the tests would be skipped. Instead of doing so, an assembly level skip will be added. This PR looks to make the System.Threading.Tasks.Dataflow test suite pass on WebAssembly.Contributes to #38422