-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Disable threading tests in System.Threading.Tasks.Extensions #38554
[wasm] Disable threading tests in System.Threading.Tasks.Extensions #38554
Conversation
Tagging subscribers to this area: @tarekgh |
I have the same feedback on this that I've had on other such PRs. This is effectively disabling all of the meaningful tests for this library, and doing so in a noisy manner. If the problem is that "async Task" tests aren't supported, we should instead invest in adding support for that, and until it's supported, just disable the whole library's tests. |
@stephentoub We'll disable tests for this whole library and others that fall into the same category. Separately, it would be helpful to get your perspective on how we might fix |
Where is the code for the runner?
Change how? If you're testing asynchronous functionality, what is it you'd do differently? |
The runner is here (@akoeplinger please fill in more detail if I miss anything) And following your post is something I've found worked (for some tests that were previously failing) https://devblogs.microsoft.com/pfxteam/await-synchronizationcontext-and-console-apps/ |
Then why can't that approach be built into the runner? Fundamentally, that's what needs to be done: rather than blocking waiting for the task, hook up a callback to the task and use whatever mechanisms are available to pump until that callback is invoked. |
c4b97e0
to
469c133
Compare
I worked with @akoeplinger on this today. He has a solution. Let's stop putting up PRs that disable every |
When disabling tests with
async Task
, about half the tests would be skipped. Instead of doing so, an assembly level skip will be added. This PR looks to make the System.Threading.Tasks.Extensions test suite pass on WebAssembly.Tests run: 0, Errors: 0, Failures: 0, Skipped: 0. Time: 0.004518s
Contributes to #38422