Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webassembly Runtime Tests #38556

Merged
merged 196 commits into from
Aug 26, 2020
Merged

Webassembly Runtime Tests #38556

merged 196 commits into from
Aug 26, 2020

Conversation

naricc
Copy link
Contributor

@naricc naricc commented Jun 29, 2020

This PR enables pri0 runtime tests for Wasm.

@SamMonoRT
Copy link
Member

@steveisok @directhex - this is the draft PR to get the runtime tests running on wasm in CI. Need help in getting the next steps in place to run it in Helix. Any suggestions from your experience getting the library tests going in CI ?

@ghost
Copy link

ghost commented Jul 2, 2020

Tagging subscribers to this area: @directhex
Notify danmosemsft if you want to be subscribed.

@SamMonoRT
Copy link
Member

This is for "linux-wasm-js - INT" testing CI lane from #33381

src/coreclr/tests/build.proj Outdated Show resolved Hide resolved
@naricc
Copy link
Contributor Author

naricc commented Aug 25, 2020

@ViktorHofer Any additonal changes here regarding the liveBuild.targets APIs, or is it all set?

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the part for which I requested changes (how libraries libs are referenced). Thanks

@naricc naricc merged commit b9fd5a9 into dotnet:master Aug 26, 2020
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants