Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Add assembly level skip for System.Net.Requests on Browser #38674

Merged

Conversation

mdh1418
Copy link
Member

@mdh1418 mdh1418 commented Jul 1, 2020

When running the tests for System.Net.Requests on Browser, the tests that hang all have async Task. Until there is support for these tests, an assembly level skip will be added to skip the entire test suite. This PR looks to make the System.Net.Requests.Tests test suite pass on WebAssembly.
Tests run: 0, Errors: 0, Failures: 0, Skipped: 0. Time: 0.003914s

Contributes to #38422

The following is the git diff --stat showing the corresponding changes if hanging tests were disabled instead of the entire suite.

src/libraries/System.Net.Requests/tests/FileWebRequestTest.cs                      |  2 +-
src/libraries/System.Net.Requests/tests/HttpWebRequestTest.cs                      | 52 ++++++++++++++++++++++++++--------------------------
src/libraries/System.Net.Requests/tests/HttpWebResponseHeaderTest.cs               |  6 +++---
src/libraries/System.Net.Requests/tests/HttpWebResponseTest.cs                     | 12 ++++++------
src/libraries/System.Net.Requests/tests/RequestStreamTest.cs                       | 40 ++++++++++++++++++++--------------------

@mdh1418 mdh1418 added the arch-wasm WebAssembly architecture label Jul 1, 2020
@ghost
Copy link

ghost commented Jul 1, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@mdh1418 mdh1418 force-pushed the mdhwang/skip_system_net_requests_tests branch from 6c0b435 to 3bc5437 Compare July 1, 2020 17:07
@akoeplinger akoeplinger merged commit 0e870df into dotnet:master Jul 2, 2020
@mdh1418 mdh1418 deleted the mdhwang/skip_system_net_requests_tests branch July 2, 2020 13:39
@MaximLipnin
Copy link
Contributor

System.Net.Request is modified to throw PNSE at assembly level on Browser WASM in #40274.

@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
arch-wasm WebAssembly architecture area-System.Net
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants