WASM Re-enable Threading.Channels serialization tests #39016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
approved these changes
Jul 9, 2020
steveisok
approved these changes
Jul 9, 2020
|
That said, #38963 appears to be disabling BinaryFormatter entirely for wasm, so... maybe this should stay disabled, albeit with a better attribute? |
|
Hmm, yeah maybe we should just skip the test with |
|
Fixed to instead just skip it in that platform. |
akoeplinger
reviewed
Jul 9, 2020
src/libraries/System.Threading.Channels/tests/ChannelClosedExceptionTests.netcoreapp.cs
Outdated
Show resolved
Hide resolved
akoeplinger
approved these changes
Jul 9, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #37648
This test was fixed by: #38948