Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader heap enumeration api's (ICorDebugProcess11) #39124

Merged
merged 5 commits into from
Jul 15, 2020

Conversation

hoyosjs
Copy link
Member

@hoyosjs hoyosjs commented Jul 10, 2020

It's easier to review by commit and ignore the second commit and whitespace

@hoyosjs hoyosjs added this to the 5.0.0 milestone Jul 10, 2020
@hoyosjs hoyosjs requested review from noahfalk and davmason July 10, 2020 22:12
@ghost
Copy link

ghost commented Jul 10, 2020

Tagging subscribers to this area: @tommcdon
Notify danmosemsft if you want to be subscribed.

@jkotas
Copy link
Member

jkotas commented Jul 10, 2020

Is it just to make the broken eeheap SOS command work, or do we have a real end-to-end diagnostic experience in mind for this?

FWIW, I do not think that the SOS command that enumerates the loader heaps is particularly useful. I have filled the issue because of somebody reported it via email.

@davmason
Copy link
Member

This is a request from the VS team, they want to be able to know if a memory address is either on the GC heap (there's already an API for getting the GC heap segments) or on the runtime's loader heap (this API). They will use it to do some heuristics about what data target to read from in a managed TTT

@hoyosjs hoyosjs force-pushed the juhoyosa/loaderheap-enum branch from a388b26 to 045ba03 Compare July 10, 2020 23:19
Copy link
Member

@noahfalk noahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM : )

src/coreclr/src/inc/cordebug.idl Show resolved Hide resolved
src/coreclr/src/debug/daccess/dacdbiimpl.cpp Outdated Show resolved Hide resolved
@ghost
Copy link

ghost commented Jul 15, 2020

Hello @hoyosjs!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost
Copy link

ghost commented Jul 15, 2020

Apologies, while this PR appears ready to be merged, I've been configured to only merge when all checks have explicitly passed. The following integrations have not reported any progress on their checks and are blocking auto-merge:

  1. DotNet Maestro - Int
  2. DotNet Maestro
  3. Dependabot

These integrations are possibly never going to report a check, and unblocking auto-merge likely requires a human being to update my configuration to exempt these integrations from requiring a passing check.

Give feedback on this
From the bot dev team

We've tried to tune the bot such that it posts a comment like this only when auto-merge is blocked for exceptional, non-intuitive reasons. When the bot's auto-merge capability is properly configured, auto-merge should operate as you would intuitively expect and you should not see any spurious comments.

Please reach out to us at fabricbotservices@microsoft.com to provide feedback if you believe you're seeing this comment appear spuriously. Please note that we usually are unable to update your bot configuration on your team's behalf, but we're happy to help you identify your bot admin.

@hoyosjs
Copy link
Member Author

hoyosjs commented Jul 15, 2020

@Anipik do you know where these came from? These look like services/bot accounts. Do we have a check for them?

@hoyosjs hoyosjs merged commit 1bdcd66 into master Jul 15, 2020
@hoyosjs hoyosjs deleted the juhoyosa/loaderheap-enum branch July 15, 2020 10:12
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants