Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wasm] Enable System.Runtime.Serialization.Json test suite #39193

Merged

Conversation

MaximLipnin
Copy link
Contributor

@MaximLipnin MaximLipnin commented Jul 13, 2020

Part of #38422.

This PR enables System.Runtime.Serialization.Json.ReflectionOnly and System.Runtime.Serialization.Json test suites.

Two test failures which should be fixed by oncoming ICU support changes:

  • DataContractJsonSerializerTests.DCJS_VerifyDateTimeForFormatStringDCJsonSerSettings
  • DataContractJsonSerializerTests.DCJS_VerifyDateTimeForDateTimeFormat

@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@akoeplinger akoeplinger merged commit 6ecbb4d into dotnet:master Jul 14, 2020
@MaximLipnin MaximLipnin deleted the wasm_System.Runtime.Serialization.Json branch July 14, 2020 10:23
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants