WASM: Disable thread related tests on System.IO.Compression #39231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They try to test various conditions that only work if you have multiple threads which is not the case on WebAssembly.
99 tasks
danmoseley
approved these changes
Jul 13, 2020
stephentoub
reviewed
Jul 14, 2020
| @@ -14,7 +14,7 @@ public abstract class CompressionStreamUnitTestBase : CompressionStreamTestBase | |||
| { | |||
| private const int TaskTimeout = 30 * 1000; // Generous timeout for official test runs | |||
|
|
|||
| [Fact] | |||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsThreadingSupported))] | |||
There was a problem hiding this comment.
Assuming the issue here is the blocking, these tests could be made to work; there just wasn't a reason to avoid the blocking previously.
How do we want to track the difference between "this test can never work with wasm" and "this test doesn't currently work with wasm but could be made to"?
There was a problem hiding this comment.
My plan was to do a pass over all the PlatformDetection.IsThreadingSupported items once we have more capacity to actually analyze/rewrite the tests. Right now the focus is on getting as much coverage up as possible for preview8.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They try to test various conditions that only work if you have multiple threads which is not the case on WebAssembly.