Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable System.Net.HttpListener.Tests for TailcallStress #39315

Merged
merged 1 commit into from
Jul 15, 2020
Merged

Disable System.Net.HttpListener.Tests for TailcallStress #39315

merged 1 commit into from
Jul 15, 2020

Conversation

BruceForstall
Copy link
Member

Issue: #39309

@ghost
Copy link

ghost commented Jul 14, 2020

Tagging subscribers to this area: @dotnet/ncl
Notify danmosemsft if you want to be subscribed.

@wfurt
Copy link
Member

wfurt commented Jul 14, 2020

would it make sense to disable just the one test or do you see more failures in the assembly?
I think it is ok to exclude it on coreclr stress for now.

@BruceForstall
Copy link
Member Author

@wfurt I tried to disable just one, then two, then 5, then I gave up because it seems like there are many failures due to this particular stress mode and I didn't want to keep spending time trying to find them all.

wfurt
wfurt approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

erozenfeld
erozenfeld approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@erozenfeld erozenfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BruceForstall BruceForstall merged commit a4065df into dotnet:master Jul 15, 2020
@BruceForstall BruceForstall deleted the DisableFor39309 branch July 15, 2020 05:38
@jaredpar jaredpar mentioned this pull request Jul 15, 2020
Closed
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@stephentoub stephentoub stephentoub approved these changes

@erozenfeld erozenfeld erozenfeld approved these changes

@wfurt wfurt wfurt approved these changes

Assignees
No one assigned
Labels
area-System.Net
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@BruceForstall @wfurt @stephentoub @erozenfeld @karelz @Dotnet-GitSync-Bot