WASM: Enable System.Memory tests #39319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One test failed with an issue: dotnet#39311 Also noticed that StringTests.cs is included from the CommonPath, this is a historical artifact from when System.Memory built for netfx/netstandard so we could run tests on those configs. We no longer need it since StringTests.cs is already ran in System.Runtime.Tests.
99 tasks
safern
reviewed
Jul 14, 2020
| @@ -171,8 +171,6 @@ | |||
| <Compile Include="ReadOnlySpan\ToArray.cs" /> | |||
| <Compile Include="ReadOnlySpan\ToString.cs" /> | |||
| <Compile Include="ReadOnlySpan\ToUpperLower.cs" /> | |||
| <Compile Include="$(CommonTestPath)Tests\System\StringTests.cs" | |||
There was a problem hiding this comment.
We're just removing the file from the csproj and not moving it down to System.Runtime.Tests to avoid conflicts since I'll be putting up a PR soon to fix tests on Browser in that file.
safern
approved these changes
Jul 14, 2020
stephentoub
approved these changes
Jul 14, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One test failed with an issue: #39311
Also noticed that StringTests.cs is included from the CommonTestPath, this is a historical artifact from when System.Memory built for netfx/netstandard so we could run tests on those configs.
We no longer need it since StringTests.cs is already ran in System.Runtime.Tests.