WASM: Fix System.IO.MemoryMappedFiles tests #39355
Conversation
| @@ -696,13 +697,13 @@ private void WriteToReadOnlyFile(MemoryMappedFileAccess access, bool succeeds) | |||
| public void WriteToReadOnlyFile_ReadWrite(MemoryMappedFileAccess access) | |||
| { | |||
| WriteToReadOnlyFile(access, access == MemoryMappedFileAccess.Read || | |||
| (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && geteuid() == 0)); | |||
| (!RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && PlatformDetection.IsSuperUser)); | |||
There was a problem hiding this comment.
Is it fine to remove !RuntimeInformation.IsOSPlatform(OSPlatform.Windows) && since it feels redundant to check for windows twice when IsBrowser is false? Would hitting PNSE on windows be a problem?
There was a problem hiding this comment.
Given the way that IsSuperUser is written, if we remove the Windows check here, it would throw PlatformNotSupportedException and crash the tests.
There was a problem hiding this comment.
no we need to keep this since PlatformDetection.IsSuperUser would throw PlatformNotSupportedException if we ran it on Windows
edit GitHub didn't load @safern's comment at first so sorry for the double post 😄
| @@ -768,6 +769,7 @@ public void LeaveOpenRespected_OutstandingViews(bool leaveOpen) | |||
| /// Test to validate we can create multiple maps from the same FileStream. | |||
| /// </summary> | |||
| [Fact] | |||
| [PlatformSpecific(~TestPlatforms.Browser)] // the emscripten implementation doesn't share data | |||
There was a problem hiding this comment.
What does it mean? Is the behaviour unexpected?
There was a problem hiding this comment.
@marek-safar kind of, though sharing an mmap'd file is not the common case. we could probably looking into detecting the situation and throwing a proper exception (right now the second mmap just doesn't see the modifications from the first mmap)
There was a problem hiding this comment.
Please create a tracking issue instead of ignoring the tests
ghost
locked as resolved and limited conversation to collaborators
Allows the tests to run on WebAssembly:
Tests run: 329, Errors: 0, Failures: 0, Skipped: 5. Time: 1.0009759s